Skip to content

[executorch][cuda] Test 3-D convolutions on the implicit-GEMM template - #25090

Open
Gasoonjia wants to merge 2 commits into
gh/Gasoonjia/116/basefrom
gh/Gasoonjia/116/head
Open

Gasoonjia wants to merge 2 commits into
gh/Gasoonjia/116/basefrom
gh/Gasoonjia/116/head

Conversation

@Gasoonjia

@Gasoonjia Gasoonjia commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

The implicit-GEMM template accepts 3-D convolutions, but they were neither tested nor measured at 3-D shapes, including convolutions after an explicit pad (padding 0, the pad left as its own node, as causal time padding is written).

No template code changes. A benchmark case can carry an explicit pad, which both paths run before a padding-0 convolution as in the exported graph, and the shapes suite gains 3-D convolutions: causal 3x3x3 after an explicit pad, 1x1x1, and (3,1,1) with stride (2,1,1), at 96 to 640 channels. None is significantly faster than Inductor at all its shapes in bf16, so worth_routing is unchanged and Inductor keeps them; the 1x1x1 case compiles and matches eager through the Triton-only lowering, which uses Inductor's 3-D conv template.

test_conv_implicit_gemm.py runs every schedule on 3-D geometries and lowers a 3-D block by default (Inductor) and with every template accepting (all three convolutions routed, the pad kept), against eager. test_conv_routing.py checks each 3-D case through both APIs and that the causal pad stays a separate node.

This diff was authored with Claude Code.

Differential Revision: D129802595

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25090

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit 40ad43a with merge base dea39f0 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2026
@Gasoonjia
Gasoonjia deployed to upload-benchmark-results November 14, 2026 10:18 — with GitHub Actions Active
[ghstack-poisoned]
@Gasoonjia
Gasoonjia deployed to upload-benchmark-results November 15, 2026 15:43 — with GitHub Actions Active

This branch was successfully deployed

1 active and 1 inactive deployments
upload-benchmark-results — 40ad43a2 Deployed Nov 15, 2026 by Gasoonjia via upload-benchmark-results #22543
cadence — 40ad43a2 Deployed Nov 15, 2026 by Gasoonjia via hifi5s-op-test / hifi5s #38444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant