Repository navigation
refactor(permissions): move to the module layout - #852
Merged
Merged
Conversation
constants/service/registry sync/write safety/group labels -> core/, grant source, role invalidation and user cleanup -> grants/ (domain area), deps and endpoints -> web/, pages/components -> ui/components. Tests mirror the areas. permissions.deps and permissions.group_labels stay as deprecated sys.modules aliases (remove_in 0.0.46). The durable handler name permissions.user_cleanup.purge_user_grants is unchanged. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
7ca2fc7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2709d647.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-permissions.simple-module-python.pages.dev |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/permissionstodocs/module-layout.md, same pattern as #846 (branding).constants/service/group_labels/write_safety/_registry_sync->permissions/core/grants,role_invalidation,user_cleanup->permissions/grants/(new domain area inDOMAIN_AREAS;grants.pyis nowgrants/source.py)depsandendpoints->permissions/web/pages/components/->ui/components/, page and tests-js imports rewrittentest_permissions_*basenamespermissions.depsandpermissions.group_labelsstay as deprecatedsys.modulesaliases (remove_in0.0.46) becausesmpy_modulesimportsgroup_labelsand the docs promiseddeps.No logic changes: permission names, i18n keys, routes and the durable handler name
permissions.user_cleanup.purge_user_grantsare unchanged.Verification
make lint,make doctor,make ci-api-types-fresh,make ci-docs-build,make ci-css-buildpassmake test-py(8143 passed),make test-js(898) pass, run on the move commit; the follow-up commit only edits one CHANGELOG linepermissions.deps is permissions.web.deps, same forgroup_labels) checkedhttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq