Repository navigation
refactor(settings): follow the module layout (moves only) - #857
Merged
Merged
Conversation
The scoped key/value service and its helpers, constants, the module's own
settings, errors and invalidation -> core/; per-module settings discovery,
field metadata, the SYSTEM-scope store, reload and editor props ->
module_settings/ (domain area); deps, query parsing, key autocomplete and
endpoints -> web/; pages/components -> ui/components. Tests mirror the areas.
settings.{service,store,reload,constants,deps,tenant_scope,tenant_view} and
settings.endpoints.module_api stay as deprecated sys.modules aliases
(remove_in 0.0.46). The #500 re-exports hydrate, module_registry and
registration stay at the root until their 0.1.0 removal; the layout test
lists them explicitly.
Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…secrets until 0.1.0 docs/framework/settings.md promised these re-exports no earlier than 0.1.0, so their layout aliases expire then instead of 0.0.46. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Deploying simple-module-python with
|
| Latest commit: |
a8aa3ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d497866.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-settings.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/settingstodocs/module-layout.md, same pattern as #852 (permissions) and #856 (tenants).settings/core/store,reload,_module_settings.py(nowdiscovery.py),_module_settings_props.py(nowprops.py),_field_meta->settings/module_settings/(new domain area inDOMAIN_AREAS)deps,browse_query,known_keysandendpoints->settings/web/pages/components/->ui/components/, page and tests-js imports rewrittentest_settings_*basenamessettings.{service,store,reload,constants,deps,tenant_scope,tenant_view}andsettings.endpoints.module_apistay as deprecatedsys.modulesaliases (remove_in0.0.46) because branding, tenants, mail and smpy_modules import themsettingsplugin module has become de facto framework; make the dependency explicit #500 re-exportshydrate,module_registryandregistrationstay at the root until 0.1.0 and are listed inDEPRECATED_ROOTintest_module_layouterrors,services,env_vars,_secrets, ...) have no alias; the CHANGELOG says soNo logic changes: permission names, i18n keys, stored settings keys, the
settings.valuesinvalidation channel andapp.state.settingsare unchanged.Verification
make lintandPYTEST_WORKERS=8 make test-py(8143 passed, 47 skipped) passmake test-js(898),make doctor,make ci-css-build,make ci-api-types-fresh,make ci-docs-buildpasssmpy settings --helpworks,test_durable_wire_names.pyand thetest_deprecation_expiry.pyentries are unchanged vs main. The one docs finding (stale "silent re-export" wording, unlisted unaliased paths) is fixed in the second commithttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq