Repository navigation
refactor(audit_log): move to the module layout - #853
Merged
Merged
Conversation
constants/settings/services/capture -> core/; the read side (query service, filters, resolve, activity feed, CSV export) -> entries/ (domain area); deps and endpoints -> web/; pages/components -> ui/components. Tests mirror the areas with test_audit_log_* basenames. The simple_module.audit_sinks entry point now names audit_log.core.capture:audit_callback. Nothing outside the module imported a moved path, so there are no aliases. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
fdd5888
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4091bf8d.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-audit-log.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/audit_logtodocs/module-layout.md, same pattern as #852 (permissions).capture,constants,services,settings->audit_log/core/activity,export,filters,resolve,service->audit_log/entries/(new domain area inDOMAIN_AREAS)depsandendpoints->audit_log/web/pages/components/->ui/components/, page and tests-js imports rewrittentest_audit_log_*basenames and a roottests/conftest.pysimple_module.audit_sinksentry point now namesaudit_log.core.capture:audit_callbackNo logic changes: permission names, i18n keys, routes and
app.stateattributes are unchanged.Verification
make lint,make doctor,make ci-api-types-fresh,make ci-docs-build,make ci-css-buildpassmake test-py(8143 passed) andmake test-jspass, run on this commit; the branch is level withorigin/main, so no rebase was neededdiscover_audit_callback()returnsaudit_log.core.capture.audit_callback, and the installed entry point metadata matchespyproject.tomlhttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq