Repository navigation
refactor(auth): move to the module layout - #854
Merged
Merged
Conversation
constants and state -> core/; deps, middleware and route matching -> web/. oidc_common/ stays put as a declared domain area (the provider-neutral OIDC helpers oidc and keycloak share). Tests mirror the package with test_auth_* basenames. auth.constants, auth.state, auth.deps and auth.middleware stay as deprecated sys.modules aliases (remove_in 0.0.46). Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
afa4023
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca5ecb14.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-auth.simple-module-python.pages.dev |
This was referenced Nov 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/authtodocs/module-layout.md, same pattern as #852 (permissions).constants,state->auth/core/deps,middleware,_route_match->auth/web/oidc_common/stays as a declared domain area (DOMAIN_AREAS)test_auth_*basenamesauth.constants,auth.state,auth.depsandauth.middlewarestay as deprecatedsys.modulesaliases (remove_in0.0.46)No logic changes: i18n keys (
auth.errors.*), session keys andapp.state/request.stateattributes are unchanged. The only observable difference is that therequire_permissiondeprecation is now registered asauth.web.deps.require_permission.Verification
make test-py(8143 passed),make test-js(898),make lint,make doctor,make ci-css-build,make ci-api-types-fresh,make ci-docs-buildall passmake lintpasses; 376 targeted tests passauth.constants is auth.core.constants, same for state, deps, middleware);uv run python -W error::DeprecationWarning -c "import host.main"exits 0; moved files byte-identical apart from one import path; two stale doc references fixed in a follow-up commithttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq