Repository navigation
refactor(tenants): follow the module layout (moves only) - #856
Merged
Merged
Conversation
constants/settings/services/errors, the tenant service with its membership,
owner-guard and deletion helpers, and user cleanup -> core/; resolver, host
resolver and token tenant -> resolution/; invitations and the invitation mail
with its template -> invitations/; deps, shared props and endpoints -> web/;
components and hooks -> ui/. Tests mirror the areas with test_tenants_*
basenames. tenants.{constants,resolver,service,deps,errors} stay as deprecated
sys.modules aliases (remove_in 0.0.46). Durable handler names, permission
names and invalidation channels are unchanged.
Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
docs/modules/tenants.md documented importing make_host_invalidator from it. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Deploying simple-module-python with
|
| Latest commit: |
9d02e87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bfce519.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-tenants.simple-module-python.pages.dev |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of
modules/tenantstodocs/module-layout.md, same pattern as #852 (permissions).constants/service/errors->tenants/core/resolver,host_resolver->tenants/resolution/; invitation service and mail ->tenants/invitations/(new domain areas inDOMAIN_AREAS); the invitation template moves toinvitations/templates/(INVITATION_TEMPLATEupdated, wheel verified)deps, endpoints ->tenants/web/; page components and hooks ->ui/{components,hooks}, page and tests-js imports rewrittentest_tenants_*basenamestenants.{constants,resolver,service,deps,errors}stay as deprecatedsys.modulesaliases (remove_in0.0.46) becausesmpy_modulesimports them.No logic changes: permission names, i18n keys, invalidation channels (
tenants.membership,tenants.hosts,tenants.seats), app.state attributes and the durable namestenants.user_cleanup.purge_user_memberships/tenants.send_invitation_emailare unchanged;host/tests/test_durable_wire_names.pyis untouched.Verification
make lint(re-run after rebasing onto refactor(auth): move to the module layout #854),make doctor,make ci-api-types-fresh,make ci-docs-build,make ci-css-buildpassmake test-py(8143 passed) andmake test-js(898) pass on the pre-rebase commit; after the rebase 177 targeted tests pass andpython -W error::DeprecationWarning -c 'import host.main'workshttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq