Skip to content

refactor(mail): move to core/ and delivery/ module layout (moves only) - #829

Merged
antosubash merged 3 commits into
mainfrom
refactor/layout-mail
Nov 5, 2026
Merged

antosubash merged 3 commits into
mainfrom
refactor/layout-mail

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • Moves-only restructure of the mail module to docs/module-layout.md (feat(layout): core/web/ui module layout for new modules (PR 0) #827): constants/settings/state/data_compatibility to mail/core/, sender/runtime to mail/delivery/ (declared in DOMAIN_AREAS); tests mirror areas under modules/mail/tests///.
  • mail.settings and mail.constants stay as deprecated sys.modules aliases (remove_in 0.0.46); our own code never imports them.
  • host/tests/test_deprecation_expiry.py auto-discovers such layout shims; test_module_layout allows them at the root. docs/module-layout.md compat section updated to match. No logic changes.

Verification

  • make lint, make ci-docs-build, make doctor green
  • make test-py: 7850 passed, 45 skipped; make test-js green
  • Fresh interpreter python -W error::DeprecationWarning -c "import mail.module, mail.core.*, mail.delivery.*" succeeds

Test plan

  • CI is green
  • Review the moves (git detects renames at 85-97%)

https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq

constants, settings, state and data_compatibility move to mail/core/,
sender and runtime to mail/delivery/; tests mirror them. mail.settings and
mail.constants stay as deprecated aliases until 0.0.46. Layout shims are
discovered by test_deprecation_expiry and allowed at the root by
test_module_layout.

Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06e9d64
Status: ✅  Deploy successful!
Preview URL: https://7fd48a7f.simple-module-python.pages.dev
Branch Preview URL: https://refactor-layout-mail.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T15:27:44.470072Z 06e9d64 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant