Skip to content

refactor(keycloak): follow the module layout (moves only) - #838

Merged
antosubash merged 5 commits into
mainfrom
refactor/layout-keycloak
Nov 5, 2026
Merged

antosubash merged 5 commits into
mainfrom
refactor/layout-keycloak

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Moves-only restructure of the keycloak module to docs/module-layout.md (same pattern as #829/#830/#831/#834/#836).

  • constants/settings/state -> keycloak/core/
  • provider/oidc/renewal/directory/persistence/tokens/jwks -> keycloak/identity/ (declared in DOMAIN_AREAS)
  • endpoints -> keycloak/web/
  • tests mirror the areas with module-prefixed basenames
  • keycloak.{constants,settings,provider,jwks,tokens} stay as deprecated sys.modules aliases (remove_in 0.0.46) because smpy_modules imports them
  • CHANGELOG notes that moved modules log under their new module paths
  • host/tests/test_module_layout.py ignores package dirs holding only pycache
  • stale path references in docs and a users test updated

No logic changes.

Verification

make lint, make ci-docs-build, make test-py (7850 passed), make test-js, make doctor (0 errors). Browser smoke skipped: keycloak needs a live Keycloak.

https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq

constants, settings and state move to keycloak/core/; the provider, OIDC
client, renewal, directory, cache persistence, token encryption and JWKS
to keycloak/identity/; endpoints to keycloak/web/. Tests mirror the
areas. keycloak.{constants,settings,provider,jwks,tokens} stay as
deprecated aliases until 0.0.46. CHANGELOG notes that moved modules log
under their new paths.

Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
A checkout of an older branch leaves __pycache__-only directories behind;
they are not part of the package and must not fail the root-layout test.

Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0bd85f3
Status: ✅  Deploy successful!
Preview URL: https://1d87e36d.simple-module-python.pages.dev
Branch Preview URL: https://refactor-layout-keycloak.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T17:23:57.346416Z 0bd85f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit 57fa4fd into main Nov 5, 2026
17 checks passed
@antosubash
antosubash deleted the refactor/layout-keycloak branch November 5, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant