Repository navigation
refactor(sharing): follow the module layout (moves only) - #836
Merged
Merged
Conversation
constants, settings, services, service, policy, audience and the cleanup hooks move to sharing/core/; deps, present and endpoints to sharing/web/; the page components and types to ui/. Tests mirror the areas; a root conftest keeps _sharing_support importable. sharing.policy, sharing.constants and sharing.endpoints.api stay as deprecated aliases until 0.0.46 (smpy_modules imports them). The root-layout test accepts a package that holds only aliases. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
aa61b98
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d876f859.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-sharing.simple-module-python.pages.dev |
This was referenced Nov 5, 2026
antosubash
added a commit
that referenced
this pull request
Nov 5, 2026
…the layout move (#843) * fix(feature_flags,sharing): keep durable handler names stable across the layout move Durable outbox rows are keyed by the handler's import path. The layout moves (#834, #836) changed it for feature_flags' and sharing's tenant and user cleanup handlers, so rows still waiting for delivery would retry as unknown handlers and go dead. Pin the old names as constants, freeze every durable event key and handler name in host/tests/test_durable_wire_names.py, and add the rule to the module-layout checklist. Neither move has been released. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq * test(host): freeze the framework's tenant settings cleanup handler name too Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of the
sharingmodule todocs/module-layout.md(same pattern as #829, #830, #831, #834). No logic changes.constants/settings/services/service/policy/audience/tenant_cleanup/user_cleanup->sharing/core/deps/present/endpoints->sharing/web/pages/componentsandpages/types.ts->sharing/ui/tests/conftest.pykeepstests/_sharing_support.pyimportable from nested folderssharing.policy,sharing.constantsandsharing.endpoints.apistay as deprecatedsys.modulesaliases (remove_in0.0.46) becausesmpy_modulesimports them;sharing/endpoints/is an alias-only package.host/tests/test_module_layout.pyignores alias-only packages;docs/module-layout.mddocuments both.Verification
make lint,make ci-docs-build,make ci-css-build,make test-js,make doctor(0 errors): passmake test-py: 7849 passed; the only failure was a local untracked__pycache__-onlyfeature_flags/endpointsdir (not in git), removed and re-run greensharing.endpoints.api is sharing.web.endpoints.api, policy, constants) holds; own code imports no alias path (-W error::DeprecationWarning); wheel containscore/web/uiand alias files/admin/sharing/renders after admin login, 0 console errorshttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq