Skip to content

refactor(dashboard): follow the module layout (moves only) - #831

Merged
antosubash merged 3 commits into
mainfrom
refactor/layout-dashboard
Nov 5, 2026
Merged

antosubash merged 3 commits into
mainfrom
refactor/layout-dashboard

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

Moves-only restructure of the dashboard module to docs/module-layout.md, same pattern as #829 (mail) and #830 (site_lock). No logic changes, no shims (nothing outside the module imported the old paths).

  • constants.py -> dashboard/core/
  • endpoints/, stats.py, doctor.py -> dashboard/web/
  • pages/components/** -> ui/components/** (relative imports in pages/*.tsx and tests-js rewritten; i18n keys untouched)
  • Python tests mirror areas under tests/<area>/<feature>/; test_view_routes.py renamed test_dashboard_view_routes.py for a unique basename
  • Follow-up found by CI parity check: framework/cli/tests/test_module_css_build.py probe imported @simple-module-py/dashboard/pages/components/ModuleTile; repointed to ui/components. README path and a settings comment updated.

Verification

  • make lint, make doctor, make ci-docs-build, make ci-css-build (Vite build) pass
  • make test-py: 7850 passed, 45 skipped; make test-js: 894 passed
  • Wheel contains dashboard/{core,web,ui/components}/**; python -W error::DeprecationWarning import of module/web.doctor/web.stats OK
  • Browser smoke (SQLite, :8251/:5251): /dashboard/ and /admin/doctor/ render, 0 console errors
  • Independent review: clean

https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq

constants move to dashboard/core/; endpoints, stats and doctor to
dashboard/web/; the page components from pages/components/ to
ui/components/. Tests mirror the areas. Nothing outside the module
imported the old paths, so no aliases are left.

Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T16:10:15.207350Z 8bcaea9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bcaea9
Status: ✅  Deploy successful!
Preview URL: https://00db6b2d.simple-module-python.pages.dev
Branch Preview URL: https://refactor-layout-dashboard.simple-module-python.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant