Repository navigation
refactor(feature_flags): follow the module layout (moves only) - #834
Merged
Merged
Conversation
constants, service, invalidation and tenant_cleanup move to feature_flags/core/; deps and endpoints to feature_flags/web/; the page components and shared types to ui/. Tests mirror the areas. feature_flags.constants stays as a deprecated alias until 0.0.46. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Deploying simple-module-python with
|
| Latest commit: |
31ec032
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://572ceed2.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-feature-flag.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 5, 2026
antosubash
added a commit
that referenced
this pull request
Nov 5, 2026
…the layout move (#843) * fix(feature_flags,sharing): keep durable handler names stable across the layout move Durable outbox rows are keyed by the handler's import path. The layout moves (#834, #836) changed it for feature_flags' and sharing's tenant and user cleanup handlers, so rows still waiting for delivery would retry as unknown handlers and go dead. Pin the old names as constants, freeze every durable event key and handler name in host/tests/test_durable_wire_names.py, and add the rule to the module-layout checklist. Neither move has been released. Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq * test(host): freeze the framework's tenant settings cleanup handler name too Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature_flagstodocs/module-layout.md, same pattern as refactor(mail): move to core/ and delivery/ module layout (moves only) #829 (mail), refactor(site_lock): follow the module layout (moves only) #830 (site_lock), refactor(dashboard): follow the module layout (moves only) #831 (dashboard):constants/service/invalidation/tenant_cleanuptocore/,deps.pyandendpoints/toweb/, Reactpages/components/**andpages/types.tstoui/, tests mirrored undertests/<area>/<feature>/with module-prefixed basenames.feature_flags.constantsstays as a deprecatedsys.modulesalias (remove_in0.0.46). No logic, i18n key, permission string orapp.state.feature_flags.*change; TS diffs are import paths only.core/__init__.pydocstring (ruff E501).Verification
make lint,make ci-docs-build,make ci-css-build,make doctor,make test-jsgreen;make test-py7848 passed, with only the known empty/tmp/.gitplaceholder failure (passes afterrmdir).python -W error::DeprecationWarning -c "import feature_flags.module, feature_flags.web.endpoints.views"clean; built wheel containsfeature_flags/{core,web,ui}/**./admin/feature-flagsrenders the flag table, 0 console errors.Test plan
git diff -M)https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq