Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-3/unified mods can now assign canonical move-effect IDs on Gen1–3, with validation against the host's actual battle handlers before journaling. Split Special Attack/Defense effects use the appropriate native stages. Gen2/3 also expose secondaryChance in whole percent, convert explicit odds to native fractions, and distinguish explicit 0% from a legacy zero byte's fallback behavior.
Depends on #120 and its prerequisites; merge that first. Focused review: https://github.com/Roxas2712/Gen2Recomped/compare/5528ea28a9e8f9451aa27bbc6f2d411fa8ef2e62...1d9b8ef0ae11e8faa791da895d9b3d305da1be4e
A reproducible, data-only catalog records 211 reference effect IDs from pinned Gen1Recomp maps and the host importer's native-name map, with provenance hashes. Runtime handler checks still refuse missing mechanics. Eight unimplemented Gen3 handlers remain unavailable; opaque native selectors roundtrip only with their original record, and Gen4/5 effect changes remain unavailable. Registered custom native effects keep their IDs. Unmodified detached records preserve exact native odds.
Validation:
This selects existing native behavior; it does not add missing mechanics or claim imported-ROM, RNG or pixel equivalence across engines.
Hosted workflows await maintainer approval for this fork (
action_required): API 3, ci. No hosted pass is claimed.