Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported GBA Follow Me currently has no native effect producer, so a mod-selected attack ignores the center of attention. Register effect 172 and carry its side-local position through selected target resolution and the real turn queue.
The last successful caster wins on each side. A slot replacement inherits the position; a fainted holder stops drawing attacks while its timer still suppresses Lightning Rod. Live Follow Me wins over Lightning Rod. Self/spread target policies stay authoritative. State expires at next-turn planning, with ordinary status interruption, imported priority and owned PP.
Stacked on #195. Review the three feature commits after f84dfb5. The canonical effect adapter (#121) is an additional dependency only for public
effect = "FOLLOW_ME"writes; the native feature does not require it.Validation:
The shared cases use synthetic extractor-shaped moves and actual native planning/execution, not a fresh cartridge import or full-playthrough proof. Remaining effect producers, automatic AI scoring, random-target/full RNG parity, link/called moves, damage amounts and item/switch/watch actions remain separate work. Gen1 is a read-only reference; no Gen1 change or publication is required. Hosted CI and combined-fork acceptance are reported separately.
Combined-fork acceptance: integrated into
Roxas2712:codex/portability-testing, tested runtime 218cf2c. All 212/212 engine suites, 3/3 SDK suites and B30 pass with zero FAIL lines. The same 24-worker / 354-observation comparison passes on that clean runtime. The explicit canonical-effect mod proof passes 14/14. Integration updates the old missing-handler assertion and the audited effect-section fingerprint pin; all six other populated fingerprint sections remain identical. Subsequent combined-branch commits only record validation.Hosted CI: all three workflows report
action_requiredpending maintainer approval. The dedicated contract workflow has zero executed jobs. These are separate from local acceptance.