Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported GBA Helping Hand has no native handler, so portable mods cannot support a partner's move through ordinary engine execution. Register effect 176 and apply the native 1.5 modifier to the shared calculated damage after the critical multiplier and before STAB/type rounding.
The current living partner receives support once per round. Singles, missing partners, repeated support and a helper already supported by its partner fail normally. Status interruption, Protect flags, owned PP and imported priority remain authoritative. Support persists through actions/residual collection, resets at next-turn planning and does not transfer to a replacement battler. Fixed damage and confusion self-damage remain unmodified; other generations ignore the state.
Dependencies: #196 plus the existing #178 GBA base-damage and #175 critical-order corrections. Those published changes are reused as prerequisite commits. Review the two new feature commits relative to 45f5b4e. The additional #121 effect adapter enables canonical public
effect = "HELPING_HAND"writes automatically without changing generated bindings.Validation:
Sessions use equal stats and synthetic extractor-shaped move rows, not a fresh cartridge import. Dedicated set-damage/delayed executors (Spit Up, Beat Up, Future Sight/Doom Desire), their other existing semantic differences, full ability/held-item ordering, AI scoring, called/link moves and full gameplay/RNG parity remain separately auditable surfaces. Gen1 is a read-only reference; no Gen1 source change or publication is required. Hosted CI and combined-fork acceptance are reported separately.
Combined-fork acceptance: integrated into
Roxas2712:codex/portability-testing, tested runtime bf67876. All 213/213 engine suites, 3/3 SDK suites and B30 pass with zero FAIL lines. The same 28-worker / 1,916-observation comparison passes on that clean runtime. The canonical-effect mod proof passes 12/12. Integration updates the previous missing-handler assertion and audits the intentional effect-section fingerprint change; all six other populated sections stay identical. Subsequent combined commits only record validation.Hosted CI: all five workflows report
action_requiredpending maintainer approval. The dedicated enemy-action contract workflow has zero executed jobs. These are separate from local acceptance.