Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beat Up currently reuses ordinary damage for every healthy party member. Native GBA execution instead calculates each participant's level/species-base damage independently, then applies Helping Hand, a separate critical roll and variation. The six-member fixture must produce 3, 5, 7, 4, 9 and 6 rather than six copies of the active user's damage.
Add a dedicated native party executor and a per-hit damage seam. Read eligibility after accuracy and live between callbacks; retain owned PP once, continue after breaking Substitute, stop at fainting, and preserve the source's special/neutral/noncritical event metadata. Special counter memory keeps the last direct strike, including zero HP loss under Endure. Earlier-generation fallback remains separate.
Stacked on #203. Review feature commits ade8abd, 5538fa4 and 92ade2b relative to 8c7df4d. The composed canonical effect proof additionally requires #121.
Validation:
Both engines and the contract workflow use maintained JIT-enabled LuaJIT v2.1 commit a4c064539ea931274d407e1249b4bb575424a0f4. RNG observations normalize semantic critical/variation operands; no complete raw RNG-trace parity is claimed.
Synthetic imported-shaped rows and ordinary side parties are covered. Focus Band's native adjustment schedule, joined multi-trainer/link parties, intro/tutorial controllers, animations and complete gameplay remain separate acceptance surfaces. Gen1 is read-only; no Gen1 source modification or publication is required. Combined-fork acceptance and hosted CI are reported below.
Hosted CI for 92ade2b: all five workflows report action_required pending maintainer approval. The dedicated contract workflow has zero executed jobs. Local acceptance is separate.
Combined-fork acceptance: integrated into Roxas2712:codex/portability-testing, tested clean runtime f6f3bfe. All 215/215 engine suites, 3/3 SDK suites and B30 pass with zero FAIL lines. The same 40-worker / 4,486-observation comparison passes on that clean runtime, and the real canonical-effect mod proof passes 14/14. Integration preserves the existing fourth damage-adjustment argument, GBA Substitute counter guard and battle-scoped party fallback, and updates only the audited effect-section fingerprint pin. Subsequent combined commits only record validation.
Active-species cases seed the actual native battler fields separately from retained party species; they do not claim the full Transform animation/controller path.