Skip to content

Add CPU, memory, and accelerator resource requests to PENDING span#258

Merged
morgan-wowk merged 1 commit into
masterfrom
execution-tracing-resource-requests
Jun 5, 2026
Merged

Add CPU, memory, and accelerator resource requests to PENDING span#258
morgan-wowk merged 1 commit into
masterfrom
execution-tracing-resource-requests

Conversation

@morgan-wowk

@morgan-wowk morgan-wowk commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Add resource attributes to PENDING execution spans

execution.resources.cpu, execution.resources.memory, and
execution.resources.accelerators sourced from task_spec annotations.
Enables distinguishing workload types (e.g. Nebius H100 vs GKE L4)
and correlating resource requests to execution timing.

The attributes are attached exclusively to the PENDING status span, where resource reservation is most meaningful. The function try_emit_execution_trace has been renamed to emit_execution_trace to better reflect its role.

Screenshots

Screenshot 2026-05-22 at 8.13.33 PM.png

@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch 2 times, most recently from 60be4d4 to 31bb44a Compare May 22, 2026 23:31
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch 2 times, most recently from 34ce978 to 30700b0 Compare May 23, 2026 00:06
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from 31bb44a to 652c58d Compare May 23, 2026 00:06
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 30700b0 to 5317505 Compare May 23, 2026 00:32
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch 2 times, most recently from 86bfbab to d89b973 Compare May 23, 2026 02:57
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 5317505 to 68a527c Compare May 23, 2026 02:57
@morgan-wowk morgan-wowk marked this pull request as ready for review May 23, 2026 03:22
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 68a527c to 7b0c735 Compare May 26, 2026 23:27
@morgan-wowk morgan-wowk requested a review from Ark-kun as a code owner May 26, 2026 23:27
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from d89b973 to 04de498 Compare May 26, 2026 23:27
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 7b0c735 to 93d7b73 Compare May 27, 2026 00:23
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from 04de498 to 966274a Compare May 27, 2026 00:24
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 93d7b73 to 798b90d Compare May 29, 2026 18:52
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from 966274a to 171402c Compare May 29, 2026 18:52
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from 798b90d to 573a81c Compare May 29, 2026 19:04
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from 171402c to 1610a49 Compare May 29, 2026 19:04
Comment thread tests/instrumentation/test_execution_tracing.py
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from 1610a49 to 6c1f384 Compare June 1, 2026 20:02
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch 2 times, most recently from a4c0efb to c46efa4 Compare June 1, 2026 20:14
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch 2 times, most recently from 14bd7a2 to eff598b Compare June 2, 2026 23:53
@morgan-wowk morgan-wowk force-pushed the execution-tracing-pipeline-context branch from c46efa4 to ae361e5 Compare June 2, 2026 23:53

morgan-wowk commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jun 5, 5:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 5, 5:17 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 5, 5:17 PM UTC: @morgan-wowk merged this pull request with Graphite.

@morgan-wowk morgan-wowk changed the base branch from execution-tracing-pipeline-context to graphite-base/258 June 5, 2026 17:14
@morgan-wowk morgan-wowk changed the base branch from graphite-base/258 to master June 5, 2026 17:15
execution.resources.cpu, execution.resources.memory, and
execution.resources.accelerators sourced from task_spec annotations.
Enables distinguishing workload types (e.g. Nebius H100 vs GKE L4)
and correlating resource requests to execution timing.
@morgan-wowk morgan-wowk force-pushed the execution-tracing-resource-requests branch from eff598b to f098124 Compare June 5, 2026 17:16
@morgan-wowk morgan-wowk merged commit 479f3e9 into master Jun 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants