Add cache hit/miss context to root execution span#256
Merged
Conversation
This was referenced May 22, 2026
Collaborator
Author
This was referenced May 22, 2026
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
23d81d9 to
57ba606
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
fc29bb7 to
411831d
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
57ba606 to
54e0001
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
2 times, most recently
from
df9765f to
6feaf73
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
2 times, most recently
from
6f8a30a to
a8e9b03
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
6feaf73 to
c802f2b
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
a8e9b03 to
5a111d0
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
c802f2b to
e4ead67
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
5a111d0 to
3baf255
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
e4ead67 to
015d113
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
3baf255 to
d7605f3
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
015d113 to
c8b7609
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
d7605f3 to
4871348
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
c8b7609 to
17209e2
Compare
yuechao-qin
approved these changes
May 29, 2026
yuechao-qin
left a comment
yuechao-qin
left a comment
Collaborator
There was a problem hiding this comment.
THIS IS AMAZING!!!! Can't wait to use this!
| """Cache hit/miss attributes for the root execution span.""" | ||
| attrs: dict[str, object] = {} | ||
| if execution.container_execution_cache_key is not None: | ||
| attrs["execution.cache_key"] = execution.container_execution_cache_key |
Collaborator
There was a problem hiding this comment.
What is cache key in our system/pipeline-run? Reused ID is pipeline run ID right?
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
17209e2 to
fc9dd0f
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
2 times, most recently
from
65e59b8 to
bb72260
Compare
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
fc9dd0f to
aba0640
Compare
Collaborator
Author
Merge activity
|
morgan-wowk
changed the base branch from
execution-tracing-launcher-type
to
graphite-base/256
execution.cache.hit (bool), execution.cache_key, and execution.cache.reused_from_id (on cache hits) allow tracing cache efficiency and which source execution was reused.
morgan-wowk
force-pushed
the
execution-tracing-cache-context
branch
from
aba0640 to
08903a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cache hit/miss attributes to execution root span
execution.cache.hit(bool),execution.cache_key, andexecution.cache.reused_from_id(on cache hits) allow tracing cacheefficiency and which source execution was reused.
Screenshots