Add k8s pod/cluster attributes to PENDING status span#254
Merged
Conversation
Collaborator
Author
This was referenced May 22, 2026
6581758 to
c73509f
Compare
3aa355d to
3e85d85
Compare
c73509f to
057544f
Compare
3e85d85 to
239a70c
Compare
057544f to
04630ed
Compare
239a70c to
6521dc7
Compare
2ac38c8 to
2025a32
Compare
6521dc7 to
374f9cf
Compare
yuechao-qin
requested changes
May 29, 2026
2025a32 to
d9fcf6b
Compare
374f9cf to
22df75e
Compare
Collaborator
Author
|
🤖 Re: review questions —
|
d9fcf6b to
b9f8147
Compare
22df75e to
b7aa164
Compare
yuechao-qin
reviewed
May 29, 2026
b7aa164 to
eee983b
Compare
yuechao-qin
approved these changes
Jun 3, 2026
Collaborator
Author
Merge activity
|
k8s.pod.name, k8s.namespace.name, k8s.cluster.url sourced from ContainerExecution.launcher_data. Handles kubernetes, kubernetes_job, and non-k8s launchers (SkyPilot) gracefully via early-return guards.
eee983b to
012975e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Add Kubernetes pod/cluster attributes to PENDING execution spans
k8s.pod.name,k8s.namespace.name,k8s.cluster.urlsourced fromContainerExecution.launcher_data. Handleskubernetes,kubernetes_job,and non-k8s launchers (SkyPilot) gracefully via early-return guards.
The new
_launcher_pod_attrshelper only emits attributes when the spanstatus is
PENDINGandlauncher_datais present, so spans for otherstatuses or non-Kubernetes launchers are unaffected.
Screenshots