Add launcher type and cluster URL to root execution span#255
Merged
Conversation
This was referenced May 22, 2026
Collaborator
Author
This was referenced May 22, 2026
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
2 times, most recently
from
57ba606 to
54e0001
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
3aa355d to
3e85d85
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
54e0001 to
6f8a30a
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
3e85d85 to
239a70c
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
6f8a30a to
a8e9b03
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
239a70c to
6521dc7
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
a8e9b03 to
5a111d0
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
6521dc7 to
374f9cf
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
5a111d0 to
3baf255
Compare
yuechao-qin
requested changes
May 29, 2026
yuechao-qin
left a comment
yuechao-qin
left a comment
Collaborator
There was a problem hiding this comment.
Doesn't this PR also distinguish between Nebius or not? Can you then filter on
cloud_provider = Nebius && status = <SOMETHING, Maybe Failures>?
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
3baf255 to
d7605f3
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
374f9cf to
22df75e
Compare
Collaborator
Author
|
🤖 Exactly — with this PR you can filter traces on |
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
22df75e to
b7aa164
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
d7605f3 to
4871348
Compare
yuechao-qin
reviewed
May 29, 2026
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
b7aa164 to
eee983b
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
4871348 to
65e59b8
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
65e59b8 to
bb72260
Compare
yuechao-qin
approved these changes
Jun 3, 2026
Collaborator
Author
Merge activity
|
morgan-wowk
changed the base branch from
execution-tracing-launcher-data
to
graphite-base/255
execution.launcher = top-level key from launcher_data (e.g. 'kubernetes', 'kubernetes_job', 'skypilot') distinguishes launcher mechanism. k8s.cluster.url on root span allows GKE vs Nebius cluster identification by URL pattern in oasis-backend's multi-cloud setup.
morgan-wowk
force-pushed
the
execution-tracing-launcher-type
branch
from
bb72260 to
6151e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
execution.launcherandexecution.cloud_providerOTel trace attributes to root execution spanexecution.launcheris derived from the top-level key oflauncher_data(e.g.kubernetes,kubernetes_job,skypilot) and distinguishes the launcher mechanism used for a given execution.k8s.cluster.urlon the root span allows GKE vs Nebius cluster identification by URL pattern in oasis-backend's multi-cloud setup, populated fromcluster_serverinside the launcher's data block.execution.cloud_provideris read from thecloud-pipelines.net/orchestration/cloud_providertask_spec annotation, set at routing time by callers such asMultiLauncherContainerLauncher. This enables traces to be searched by cloud provider (e.g.gke,nebius) without relying on URL pattern matching against cluster hostnames. Launchers with a fixed cloud affinity can also set this annotation directly.The
CLOUD_PROVIDER_ANNOTATION_KEYconstant is defined incommon_annotationsso it can be shared across launchers and the tracing layer without duplication.Screenshots