[trissim]

A plan phase marked done blocked nothing: the multiple-inheritance plan read done at a2333ca, and then #2943, #2955 and #3130 put three of the deleted sites back with nothing in the way. Now every done phase's evidence is a standing guard on every PR.

What changed

• DonePhaseBroken in tools/debt_ratchet.py checks every phase in the Plan family registry (PlanPhase.members_with(PlanPhase), the same registry PlanPhase.done reads, so there is no second evaluator and no hand-written list).
  • It reads each phase at the base and at the head, one process per revision.
  • It fails the PR once per site for every phase done at the base and not done at the head. The report key is DonePhaseBroken:PHASE::PATH:LINE.
  • Phases not yet done at the base are skipped, so plan work in progress isn't blocked.
  • It runs only in the src matrix leg.
• PhaseEvidence.sites() returns () by default. Overrides give file:line for PatternAbsent (git grep lines), OwnClassChecksAbsent (each own-class isinstance), RestatedMembersAbsent, ClassRostersAbsent, and AllEvidence (the sites of whichever parts fail). Evidence with no line falls back to its describe().
• MainTree.modules keeps each path's last parsed blob, so one revision parses src once for all 73 phases instead of once per evidence. It is bounded by the number of paths, not by history.
• RestatedMembersAbsent compares ast.dump only for members whose names match, instead of dumping every member of every class.
• Classes uses ast.walk.

Proof

• Pinning test test_a_done_phase_fails_the_change_that_breaks_it: a fixture adds isinstance(value, Owned) on a class it declares. The result is status 1 and exactly DonePhaseBroken:OwnTypeChecksPhase::src/agent_comms/owned.py:6. A clean head passes.
• On the real repo, base e39ccce (after Reopened multiple inheritance phases: own-class isinstance and CLI failure roster become capabilities #3195) against head 0320ecf (before Reopened multiple inheritance phases: own-class isinstance and CLI failure roster become capabilities #3195) gives InheritanceCleanupPhase::src/agent_comms/cli_protocol.py:46 CLI_FAILURES, which is the roster Reopened multiple inheritance phases: own-class isinstance and CLI failure roster become capabilities #3195 deleted.
• Base a2333ca against head 3489b00 gives OwnTypeChecksPhase::src/agent_comms/field_codec.py:2382 and registry_document.py:299, plus the CLI_FAILURES roster. Those are exactly the sites re-added after the plan read done.
• Touched tests: tests/guards/test_debt_ratchet.py::test_a_done_phase_fails_the_change_that_breaks_it tests/test_phase_evidence.py tests/test_plan_stalled.py gave 32 passed.
• Cost, measured locally at load 10-12 on 12 cores with no GitHub token:
  • one revision takes 10.2 s in one process;
  • a measure with both revisions in parallel takes 11.8 s cold and 0.2 s from the ratchet cache;
  • the sites are read only when a PR fails.

🤖 Generated with Claude Code

https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.