Repository navigation
Read the done-phase source root without an origin - #3212
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
DonePhaseBroken.parts built Repo.of(repo) only to read "src", and Repo.of runs git remote get-url origin, so every ratchet run on a checkout with no origin (the test fixtures) died with GitCommandError before printing its growth lines. The root is now the top directory of the module that declares the phases, read from where it is imported; no Repo is built unless the measure runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
marked this pull request as ready for review
October 25, 2026 03:06
trissim
enabled auto-merge
October 25, 2026 03:06
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a red that #3200 put on main:
test_growth_lines_end_the_merged_log[src/agent_comms]and[src/toad], reported by fork-integrate.Cause
DonePhaseBroken.partsbuiltRepo.of(repo)only to read the default"src".Repo.ofrunsgit remote get-url origin(repo.py:191).GitCommandError: No such remote 'origin'before it printed any growth lines.Fix
plan_phases, relative to the ratchet's repository. That is where the declarations actually live.Repo.ofnow runs only when the measure actually measures.Proof:
PYTHONPATH=$PWD/src pytest -p no:xdist tests/guards/test_debt_ratchet.py -k "growth_lines_end_the_merged_log or done_phase"gave 3 passed: both formerly red cases plus the done-phase pinning test.🤖 Generated with Claude Code
https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V