Repository navigation
Test that judge reviewing withdraws an approved head's review status - #3217
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
marked this pull request as ready for review
October 25, 2026 03:28
trissim
enabled auto-merge
October 25, 2026 03:28
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tonight #3200, #3187 and #3151 each merged an approved old head while its fix was still being written.
The writer already withdraws; nobody called it.
agent-comms/reviewthrough the one writer,HeadReview.post(src/agent_comms/head_review.py:54), called fromHeadVerdict.reviewed(src/agent_comms/todos.py:3337).judge backpostsRejectedHeadVerdict.state = "failure", andjudge reviewingpostsUnderReviewHeadVerdict.state = "pending"(pending since 7dac490, 10-24 06:51).judge reviewingon the old head. With no withdrawal posted, auto-merge took the old head.The test (
okthenbackon one sha was already covered attests/test_head_review.py:59):okthenreviewingon the same sha postsstate=success, thenstate=pending.UnderReviewHeadVerdict.statetosuccessmakes it fail.tests/test_head_review.py: 8 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V