Repository navigation
Batch round r2: nine ready heads, merged and tested once - #2684
Merged
Merged
Conversation
LockedStore.update now takes a change returning DocumentChange[D, R] (successor plus answer) and returns R, so callers stop smuggling results out through nonlocal (IMPL-8) in read_ledger, relationships and shared_ledger. InputDispositions._update, the same transaction over SQLite, takes the same DocumentChange. SpawnedProcess.launching yields the child before it executes, replacing the before_start callback whose result owner_lifecycle smuggled out through nonlocal. ConnectivityFacet, OwnerConnectivity, ACPClientConnectivity and observe_connectivity had no production writer: deleted with the snapshot field and their tests. RecordsPhase evidence matched its own declaration in plan_phases.py, so it could never pass; it now brackets its first letters like BusWriter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Schema installation creates declared tables and never drops undeclared ones, so every coordination database written before the facet was deleted kept the connectivity table and its four triggers (the live bus still has them, with zero rows). The carry drops the table once; SQLite drops its triggers and index with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pytest_sessionstart ran stack/bin/prepare-pi-native (npm ci, the import boundary and proof schema renders) whenever the pinned package was missing, so a run of one SQLite test in a fresh worktree paid for the whole native stack. The build is now the session fixture pinned_native, which native_runtime_package and every test that touches the package request; a run that never asks never builds. Workers asking together take the stack directory lock and the first one builds. Tests that read pinned_native_package() themselves take the fixture instead, and one_turn_events receives its package. Deleted the dead helpers that pulled native into modules that never used it: _replay_stub, _NATIVE_PROMPT_START, _rpc_events and _assert_full_rpc_stream in test_backend.py, and stub and collect_backend in test_mcp_relay.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LockedStore.update now takes a change returning DocumentChange, but the
four connector routes still handed it bare ConnectorGrants, so /register,
/authorize, /confirm and /token answered 500 ('ConnectorGrants' object has
no attribute 'document').
register and authorize return DocumentChange.to. confirm and token return
their answer as the change's result, deleting the approved and exchanged
lists that smuggled it out (IMPL-8). ConnectorGrants.issued and
TokenGrant.exchange return DocumentChange instead of an unnamed pair, so
token passes grant.exchange to the store directly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/agent_comms/diagnostics.py
# Conflicts: # src/agent_comms/private_registry_guard.py
# Conflicts: # src/agent_comms/goal_attempts.py
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-tools at 186bab3, every finding: |
This was referenced Oct 23, 2026
|
debt-src at 186bab3, every finding: |
trissim
pushed a commit
that referenced
this pull request
Oct 23, 2026
e1e82d6 (#2684) deleted test_backend._replay_stub and _NATIVE_PROMPT_START; test_native_refusal_recovery.py still imported them for helpers no test calls since e16d8df deleted the fake-backed tests. Collection died on main. The one real test stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round two of batch merging: every ready head merged once into one branch from main and tested once.
Carries #2661 (with its connector fix eab807d), #2669, #2670, #2676, #2671, #2672, #2674, #2675 and #2678. Nothing dropped.
Merge conflicts resolved once:
Resolutions made in this branch:
Proof:
What the run-1 reds were:
🤖 Generated with Claude Code