Repository navigation
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 08:13
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commander parity was permanently false:
ParityRow.donecalledcompareon every row, and every row inherited a method that returned UnverifiedParity unconditionally. Demonstration workflows could pass without ever affecting that gate.ParityEvidencenow consumes the same native evidence declared byParityPhase.after: record-plane delivery, the required review rule without bypass actors, old control-script deletion, and CommanderPagePhase's Core HUD/tool declarations. The dependency tuple is declared once; evidence is derived from it. Cutover consumes that exact parity evidence and still requires CommanderConfig to be absent. Missing native evidence remains false. No manual status, second completion store or demo-result stamp is introduced.Delete the standing-rule profiler comparison: it observed an owner's own return and compared that return with the owner's output. Delete the plain-word comparison that called the same text owner through a forwarding CLI helper and directly. Its only remaining wording consumer compares genuinely distinct CLI order validation and native request entrypoints; that diagnostic remains. Native operation/copy/boundary journeys remain available for the integrator; optional capability diagnostics do not grant cutover.
Stacked on the Core HUD branch next/commander-hud (#2670), itself stacked on #2654. No tests/scans/censuses run under Tristan's worker stop. Integration owns changed phase, import, commander and retained boundary checks once.
Assumed: this phase certifies the current native owners and their declared evidence, not completion of every historical ambition in the old matrix. Automatic forking, UnitTime and the full installed Toad page remain their own work. An active review-bypass actor still prevents the native review evidence from passing. This source delivery claims no current live parity pass.
Final head: ca578d1. Against the HUD parent: 247 lines deleted, 31 added (net -216). Native evidence ownership:
plan_phases.py:228declares prerequisites;:229derives the exact evidence objects;phase_evidence.py:345reads each through the shared AllEvidence implementation;plan_phases.py:236reuses that evidence at cutover. The HUD field-owner table is in parent #2670 and remains unchanged on this branch.