Skip to content

Derive parity from native owners and delete self-comparisons - #2676

Closed
trissim wants to merge 2 commits into
next/commander-hudfrom
next/native-parity
Closed

trissim wants to merge 2 commits into
next/commander-hudfrom
next/native-parity

Conversation

@trissim

@trissim trissim commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Commander parity was permanently false: ParityRow.done called compare on every row, and every row inherited a method that returned UnverifiedParity unconditionally. Demonstration workflows could pass without ever affecting that gate.

ParityEvidence now consumes the same native evidence declared by ParityPhase.after: record-plane delivery, the required review rule without bypass actors, old control-script deletion, and CommanderPagePhase's Core HUD/tool declarations. The dependency tuple is declared once; evidence is derived from it. Cutover consumes that exact parity evidence and still requires CommanderConfig to be absent. Missing native evidence remains false. No manual status, second completion store or demo-result stamp is introduced.

Delete the standing-rule profiler comparison: it observed an owner's own return and compared that return with the owner's output. Delete the plain-word comparison that called the same text owner through a forwarding CLI helper and directly. Its only remaining wording consumer compares genuinely distinct CLI order validation and native request entrypoints; that diagnostic remains. Native operation/copy/boundary journeys remain available for the integrator; optional capability diagnostics do not grant cutover.

Stacked on the Core HUD branch next/commander-hud (#2670), itself stacked on #2654. No tests/scans/censuses run under Tristan's worker stop. Integration owns changed phase, import, commander and retained boundary checks once.

Assumed: this phase certifies the current native owners and their declared evidence, not completion of every historical ambition in the old matrix. Automatic forking, UnitTime and the full installed Toad page remain their own work. An active review-bypass actor still prevents the native review evidence from passing. This source delivery claims no current live parity pass.

Final head: ca578d1. Against the HUD parent: 247 lines deleted, 31 added (net -216). Native evidence ownership: plan_phases.py:228 declares prerequisites; :229 derives the exact evidence objects; phase_evidence.py:345 reads each through the shared AllEvidence implementation; plan_phases.py:236 reuses that evidence at cutover. The HUD field-owner table is in parent #2670 and remains unchanged on this branch.

@trissim
trissim marked this pull request as ready for review October 23, 2026 08:13
Copilot AI balanced review requested due to automatic review settings October 23, 2026 08:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim

trissim commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Landed on main through batch #2684 (merge f966a53): head ca578d1 is an ancestor of origin/main. GitHub can't mark it merged because its base is a stacked branch, and it can't be retargeted because main already contains every commit.

@trissim trissim closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants