[trissim]

Fixes the tests that are red on main. Each fix is at the owner of the broken fact, or in a test that was hand-building a shape its owner now declares differently.

Source fixes

DM peer had two encodings (IDEN-3). DMHistory.second, direct_history, fetch_page and dm_display_page took str | ThreadTarget and re-decoded the peer with CommandTarget.named. #2733 (0087dc9) narrowed that to raw strings. The peer is now a ThreadTarget everywhere, which fixes test_historical_views::test_normal_comms_api_contains_history_and_execution_stays_live.

Union failures lost their cause. field_codec.py UnionDecoder.decode_candidates (≈line 2417) skipped every alternative whose shape did not admit the value. When none admitted it, nothing was decoded and the error had no __cause__. This came from the #2712 shape filter (8d9c10e, commit 8b63ca4). Now, when the shapes rule out every alternative, the first alternative's own decode supplies the refusal. Fixes test_union_success_releases_rejected_payload_and_failure_keeps_first_cause.

Bus files were declared on bare RootFile. RetiredCommanderFile (#2743, a012a03) and UnfinishedOwnerRename (#2749, a1aab88) were neither durable nor runtime files, so install behaviour for them was undefined. Both are now DurableFile. RootFile.__init_subclass__ (locked_store.py) refuses any new declaration of that kind, which fixes test_bus_files::test_every_bus_file_is_a_declared_root_file.

StoreBackup.interrupted had no caller. It came from #2709 (27e8722). A new StoreBackup.complete_interrupted finishes and retires any restore that a killed install left behind, under a maintenance hold. upgrade() calls it first, before anything reads the bus. Fixes both cases of test_interrupted_rollback.

Activity was declared optional where it is required. assignment_states.py: SelectedResponseNotification.notification reads activity.progress, but #2450 (f9958d7, commit 69304ca) gave activity a None default. A missing activity therefore failed with an AttributeError instead of the call's TypeError. The completed and delivered states had the same type. All three now require AssignmentActivity. Fixes test_historical_notifications::test_recorded_engagement_is_not_an_active_turn.

External Pi records were refused by the union prefilter. field_codec.py _RepresentedDecoder.fits_external (new, beside fits_wire): PiReported.from_wire decodes its value with the external reader, which tolerates keys Pi adds (contextUsage.percent), but the representation admitted only the exact wire record. The #2712 prefilter (8d9c10e; bisected: the payload decodes at 8d9c10e^1 and fails at 8d9c10e) ruled ReportedContextUsage out, and PiOmitted refused the dict. The representation's external shape check now derives from its wire structure's. The codec's admits_* shape checks are renamed fits_* in the same change, because "admit" is banned vocabulary in the debt ratchet. Fixes test_installer_test_runtime::test_checkout_native_tests_use_a_private_runtime (inner: test_native_input_bus_path::test_saved_owner_dm_replies_and_core_reads_exact_native_proof).

RootFile.__init_subclass__ is annotated (**kwargs: object), so debt-src's TypeErrors and UnannotatedParameter counts for locked_store.py stay at the base's.

Test fixes (each test now uses the owner's declaration)

• test_attach_only_reads_original_roots_and_rejects_changed_snapshot: bus_files keys are typed since Integration batch: duplicates 5-8, root runtime owner, interrupted rollback, installer file identity #2709 (1a6fc31). The test now reads the member paths.
• test_frozen_unhandled_delivery_projects_recovery_without_claiming: uses Thread.incarnation instead of rebuilding it from a CreationTime (Move Pi payload and transcript decisions into their owning families #2724, d5cd4bb).
• test_debt_ratchet (4 node ids):
  • The fixture modules were never Black-formatted.
  • The Unformatted measure counted that from 512fa43 on.
  • The test's expected status only became 0 with 97256db (Make the commander rules state one landing rule, and record failure 16 #2326).
  • New module() helper formats the composed owners.
• test_bus_files (parameterized pair): asserts the DeclaredFile key (Integration batch: duplicates 5-8, root runtime owner, interrupted rollback, installer file identity #2709).
• test_store_backup (both cases): writes the route owner-only, as its owner does. Keep rollback state readable by the outgoing runtime; stop union admits recursion #2731 (699a5f6) refuses a non-private route at active_route.py:216.
• test_carry_bus_history round trip: runs every step that the chain orders before OwnerRequests, under a hold. Integration batch two: owned dispatch, closure state, field directives, retained waits, install speed, import tax #2701 (d5eac7a) inserted ClaimFields between the steps the test had picked by hand.
• test_carry_dead_turns: carried paths are Path since ded6cdd (Integration batch: duplicates 5-8, root runtime owner, interrupted rollback, installer file identity #2709).
• test_interrupted_rollback:
  • The carry commits its edit (editing() requires commit() since 8e11c30).
  • The title is a GivenThreadText.
  • The test runs on an installed runtime.
• test_native_refusal_recovery: deleted the orphaned helpers that imported _NATIVE_PROMPT_START, which Batch round r2: nine ready heads, merged and tested once #2684 (e1e82d6) removed from test_backend.
• test_field_codec union test: the test's members hand-wrote from_wire, to_wire and schema. A member inheriting a union's wire structure recursed in admits_wire once Reject impossible union wire shapes before decoding candidates #2712 started calling it. The members now inherit DeclaredWireType and RecordMember, which Keep rollback state readable by the outgoing runtime; stop union admits recursion #2731 and the codec declare for exactly this.
• test_install_session_bridge (4): bridge.pause returns one value since Port typed bridge resume outcomes and owned MRO handler lookup #2713 (ded2d7b, commit c3bd967). The tests unpacked a tuple. The swap test hands each prefix's bus to that prefix's runtime with RootRuntime.publish, as the installer does (Integration batch: duplicates 5-8, root runtime owner, interrupted rollback, installer file identity #2709). source_programs.runtime derives the runtime from its prefix.
• test_install_rehearsal:
  • Since Integration batch: duplicates 5-8, root runtime owner, interrupted rollback, installer file identity #2709 (4cad001) a root belongs to one runtime. The fixture bus was owned by the test venv, so the installed runtime was refused (ForeignRuntimeError, root_runtime.py:32).
  • installed_comms now publishes the bus to the installed runtime, and the history is read back through that runtime's own CLI.
  • The drifted case compares typed paths.

Elsewhere

• Hosted smoke "Stack clients import only modules Core has": Toad imported ViewKind, which Integration: kind families, thread-name owners, disclosure mixins, Pi event phases, phase evidence, commander package #2695 (a6a44e7) deleted. Fixed in Build the saved view from its declared family member toad#1149 (merged). This PR relocks stack/uv.lock onto toad main (336cf3e), which contains it.

Environment, not product

• "A private test runtime home requires uv on PATH": this is TestHome.uv's declared contract (installer/practice.py:86), and those cases pass with uv on PATH.
• test_install_rehearses_without_changing_the_bus under the default basetemp: it fails with "Insufficient free space before building the practice copy" when /tmp (tmpfs) has less free space than the 5 GiB StorageRule floor. It passes with --basetemp on /var/tmp.

Still red, owned by the install-23 fix

test_install_rehearsal: test_failed_publication_restores_absent_route_without_store_changes and [retained-bus] were hidden behind ForeignRuntimeError and now reach the live carry. There, live reconcile-stores (upgrade.py:955) rewrites bus.sqlite3, while planned-reconcile (upgrade.py:985) planned no rewrite. RehearsalFiles.require_rehearsal then refuses: "Live carries changed files absent from rehearsal: bus.sqlite3". This is the same defect that made install 23 refuse. The fork fixing install 23 owns it in its own PR and uses these tests as its reproduction.

Proof

All touched test files pass locally (-p no:xdist, this worktree's src on PYTHONPATH, uv on PATH). The native pin moved separately in #2766 (f3f069f).

🤖 Generated with Claude Code

[trissim]

#2764's smoke collection fails in your held tests/test_native_refusal_recovery.py:10: it imports _NATIVE_PROMPT_START and _replay_stub from test_backend, which no longer declares either. Only the dead _stub_with fixture helper uses them; the remaining test is the typed provider-failure case. Your PR already owns this file, so I am leaving the deletion with #2763. This blocks the explicitly requested green hosted checks on #2764.

Failing job: https://github.com/OpenHCSDev/agent-comms/actions/runs/39951823803/job/120407905294

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

[github-actions]

debt-src at 33003fd, every finding:

introduced NoneAbsence:src/agent_comms/field_codec.py at lines [2185]