Repository navigation
The boot and service scripts' comments are shorter, with their reasons kept - #241
Merged
Merged
Conversation
…s kept: cleanup-held's cut of build/recipes/services.sh and five service scripts, redone on main by hand, comments only From 65a6fbb, taken where the comment it shortens is still main's and the reason survives. Changed from it: boot-success's header names the slot booted from outside (#226), esp_committed is read at every boot with no trial on record, not only on a degraded state, and forget_entries keeps that the committed slot's own entry is a second way to it; testctl keeps why a control disk is read only on a medium and only when signed, and its key list is the thirteen keys main reads; time-floor keeps the newest committed release (#181); sysinit keeps a one-line list of the state's three kinds and why the consent directory is setgid. Dropped: the shortened section rulers (churn) and installer-run's shellcheck line, which predates slot_arg and kbd_arg.
This was referenced Oct 7, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup-held (65a6fbb) cut the comments of 57 files on 2026-10-05; 37 of them conflict with main now. This PR redoes its part for
build/recipes/services.shand five service scripts (boot-success.sh,installer-run.sh,sysinit.sh,testctl.sh,time-floor.sh) by hand on main, comments only. The other held files come in further small PRs, by directory. Files that an open PR touches wait until it lands.How it was done. Each file was three-way merged from cleanup-held's change onto main (
git merge-file, base 91c3238). Conflicts were resolved by hand, and each cut was kept only where the comment it shortens is still main's and the reason it gives survives. A check that strips comments from main's version and this one finds the same code in all six files;sh -npasses.Kept from the held cut: the one-line headers; sysinit's getty,
/etcupper-layer, devtmpfs, securityfs and efivarfs lines; installer-run's preseed, replace and verify lines; and boot-success's trial record line. The note thattrial.failed, not last-result, stops a re-arm moves to the branch where it is set.Changed from it:
esp_committedis now read at every boot with no trial on record, so the held comment ("state degraded: ...") is no longer true; it says when it is read.forget_entrieskeeps that the committed slot's own firmware entry is a second way to it should BOOTX64.EFI be lost.install_slot_mib,install_keyboardand theheaderrecovery mode.Dropped:
slot_argandkbd_arg.Proof: CI (shellcheck, syntax, the fixture suites). Nothing the image does changes, so there's no Distro run.