Repository navigation
The VM suites' comments are shorter, with their reasons kept - #243
Merged
Merged
Conversation
…-held's cut of install-test, state-test, update-test, suite-lib and vm-drive.py, redone on main by hand, comments only Only comment regions are taken from 65a6fbb. Kept where it corrects main: suite-lib's header names what install_disk reads. Changed from it: update-test's header keeps the broken trial, and its channel comment keeps what the not-a-pointer control is; suite-lib keeps the production pair's testctl key. Dropped with the cut, as untrue or repeated: update-test's 'plain http is for development images only' (the suite writes an http channel on either role) and the request-order comment its own pass and fail lines state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third part of the cleanup-held redo (after #241 and #242). These are comments only, in
tools/image/install-test.sh,state-test.sh,update-test.sh,suite-lib.shandvm-drive.py.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment or blank were kept. Code, messages and every conflict went back to main, and each kept cut was then read by hand. Stripping comments from main's version and this one gives the same code in all five files;
bash -npasses and vm-drive.py parses.Taken where the cut corrects main: suite-lib's header now says what
install_diskreads (TIMEOUT,VMDIR).Changed from the cut, to keep a reason it dropped:
not-a-pointercontrol is: the statement signed in the manifest's namespace, which only a development build makes.Gone with the cut, checked against the code:
channel = http://10.0.2.2:…) on either role, so it was untrue there.Proof: CI (shellcheck, syntax). These suites run only in the Distro workflow, and nothing they do changes; no file outside these five is touched.