Repository navigation
kryptikd's comments are shorter, with their reasons kept - #246
Merged
Merged
Conversation
…re shorter, with their reasons kept: cleanup-held's cut of kryptikd's sources, probes and cli suite, redone on main by hand, comments only Only comment regions are taken from 65a6fbb. Where the cut dropped a reason a shorter one is kept: the broker's peer uid is the kernel's, a zone reaches only its own clipboard and a move crosses once, None refuses every transfer, the destination is looked up again as it may have restarted, the identity switch is restored on every path; update.rs never resolves under what the net zone reports, never stages past the signed size, and its channel file is the image's; serve.rs's socket directory admits the group alone; stop signals a launcher only while its pid and start time match; and the suites' charters and orderings. Kept where the cut corrects main: the broker's request table gains transfer and clipboard-move, cli.sh's header its exit codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fifth part of the cleanup-held redo (after #241-#244). These are comments only, in kryptikd's
broker.rs,serve.rs,update.rs,zone.rs,main.rs,broker/tests.rs,update/tests.rs,Cargo.toml,probes/boundary-checks.shandprobes/fixtures.sh, andcompartments/tests/cli.sh.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment or blank were kept; code, messages and conflicts went back to main. Each kept cut was then read by hand. Stripping comments (Rust
//,///,/* */, char and string literals respected; sh#) from main's version and this one gives the same code in all eleven files;bash -npasses on the shell ones.zone/tests.rshad no comment region left.Kept where the cut corrects or adds to main:
transfer <zone> <name> (+1 fd)andclipboard-move ... -> error: ... a zone 0 act, both checked againstparse_requestand its reply.destroyneeds root too.Changed from the cut, to keep a reason it dropped:
Nonefor the home device refuses every transfer.open_nofollow'swant_socketkeeps its meaning.check --target's refusal; the TOML reader's refusal of arrays and nested tables; why a zone name is restricted (cgroup paths, interface names).Dropped from the cut: comments that only repeat the error message beside them (io_max's volume, storage.size, a persistent zone's volume); the conflicting hunks; two stray blank lines.
Proof: CI's Compartment layer (cargo test of kryptikd, which compiles every file here) and the fixture and shell checks. Nothing kryptikd does changes.