Repository navigation
The session's and the launcher's comments are shorter, with their reasons kept - #244
Merged
Merged
Conversation
…sons kept: cleanup-held's cut of tools/desktop/kryptik-launch.c and kryptik-session, redone on main by hand, comments only Only comment regions are taken from 65a6fbb. Changed from it: the launcher's header keeps that it is the daemon's one client for the keys and the menu, and that the proxy socket is bound into the zone so a zone never sees the compositor's own; its update verbs keep that apply answers once the slot is written; the session keeps that anything needing root goes to the launch daemon.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fourth part of the cleanup-held redo (after #241, #242 and #243). These are comments only, in
tools/desktop/kryptik-launch.candtools/desktop/kryptik-session.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment or blank were kept; code, messages and conflicts went back to main. Each kept cut was then read by hand. Stripping comments (
//and/* */for C,#for sh) from main's version and this one gives the same code in both;bash -npasses on the session script.Changed from the cut, to keep a reason it dropped:
applyanswers only once kryptik-update has written the slot.Dropped from the cut: two hunks that conflict with main's changes since 2026-10-05, and its message changes.
Proof: CI. Its fixture step compiles kryptik-launch.c with cc and runs it (tools/tests/launch-ask.py, launch-secrets.py), and shellcheck covers the session. Nothing either program does changes.