Repository navigation
Preserve Unicode segments when extending trie leaves - #139
Merged
Merged
Conversation
This was referenced Oct 17, 2026
mcculls
marked this pull request as ready for review
October 17, 2026 14:22
mcculls
requested review from
ValentinZakharov
and removed request for
a team
October 17, 2026 14:22
1 task done
PerfectSlayer
approved these changes
Oct 19, 2026
mcculls
force-pushed
the
mcculls/trie-builder-isolation
branch
from
October 19, 2026 16:37
5a85d45 to
22ae36d
Compare
Pass the leaf-segment context to appendLeaf instead of inferring it from the next data character, which may belong to another branch and have the leaf-marker bit set. Cover characters around the marker boundary, short and longer extensions, and subsequent insertions.
mcculls
force-pushed
the
mcculls/trie-unicode-segments
branch
from
October 19, 2026 16:39
2367fab to
948af7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Pass the leaf-segment context explicitly to appendLeaf instead of inferring it from the next data character.
Motivation
When extending a collapsed leaf, the next character can belong to another branch. If that Unicode character had the leaf-marker bit set, appendLeaf misinterpreted it as a marker, corrupted mappings, and caused later insertions to throw an array bounds exception.
Additional Notes
Regression tests cover characters around the marker boundary, short and longer extensions, and subsequent insertions.
Stack (merge in order):
This PR targets
mcculls/trie-builder-isolation.Contributor Checklist