Repository navigation
Fix long-jump table growth after compaction - #137
Merged
Merged
Conversation
This was referenced Oct 17, 2026
mcculls
marked this pull request as ready for review
October 17, 2026 14:21
1 task done
jpbempel
previously approved these changes
Oct 17, 2026
Ensure the long-jump table grows by at least one entry when a compacted trie is extended. A one-entry table previously retained its size under the 50% growth calculation, causing an array bounds exception. Cover both continuing the existing builder and constructing a new builder from the compacted trie.
mcculls
force-pushed
the
mcculls/trie-long-jump-growth
branch
from
October 19, 2026 16:35
3199436 to
d024306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Ensure the long-jump table grows by at least one entry when a compacted trie is extended.
Motivation
After buildTrie() compacted the table to one entry, the 50% growth calculation kept its size at one. Allocating a second long jump then threw ArrayIndexOutOfBoundsException.
Additional Notes
Regression coverage exercises both continuing the existing builder and constructing a new builder from the compacted trie.
Stack (merge in order):
This PR targets
mcculls/trie-long-jump-capacity.Contributor Checklist