Repository navigation
Preserve built tries when builders are modified - #138
Merged
Merged
Conversation
This was referenced Oct 17, 2026
mcculls
marked this pull request as ready for review
October 17, 2026 14:22
1 task done
amarziali
approved these changes
Oct 19, 2026
mcculls
force-pushed
the
mcculls/trie-long-jump-growth
branch
from
October 19, 2026 16:35
3199436 to
d024306
Compare
Detach shared trie data and long-jump arrays before a builder modifies them, keeping previously built tries immutable. Defer copying until the first subsequent write. Cover overwrites and long-jump updates for both reused builders and builders created from an existing trie.
mcculls
force-pushed
the
mcculls/trie-builder-isolation
branch
from
October 19, 2026 16:37
5a85d45 to
22ae36d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Detach shared trie data and long-jump arrays before the first subsequent builder write. Previously built tries retain their values and offsets.
Motivation
Builders shared arrays with built tries. Overwrites changed existing tries, while branch extensions could update shared long-jump offsets and make existing trie lookups read past the data array.
Additional Notes
Copying is deferred until a builder writes after sharing its arrays. Regression tests cover repeated builds, overwrites, and long-jump updates for reused builders and builders created from existing tries.
Stack (merge in order):
This PR targets
mcculls/trie-long-jump-growth.Contributor Checklist