Repository navigation
Preserve trie mappings when long-jump capacity is exhausted - #136
Merged
Merged
Conversation
An insertion could modify trie data before discovering that the long-jump table was full, leaving existing mappings corrupted after rejection. Check local allocations and ancestor jump conversions before modifying the trie. Use the actual insertion size so valid insertions still work when the table is full. Skip the ancestor scan when enough slots remain for every possible conversion. Add regression tests for rejected and valid insertions at capacity, plus builder benchmarks for exclusion rules, class names, and long jumps.
This was referenced Oct 17, 2026
mcculls
marked this pull request as ready for review
October 17, 2026 14:21
1 task done
amarziali
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Check local long-jump allocations and ancestor conversions before modifying the trie. Use the actual insertion size so insertions that need no additional table entries remain valid at capacity. Skip the ancestor scan when enough slots remain for every possible conversion.
Motivation
An insertion could move data or update markers before discovering that the long-jump table was full. Catching the rejection then left previously registered mappings corrupted.
Additional Notes
Adds regression tests for rejected and valid insertions at capacity, plus builder benchmarks for exclusion rules, class names, and long jumps.
Stack (merge in order):
This PR targets
main.Contributor Checklist