🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure

[seonghobae]

R/aFIPC.R 파일에서 try() 블록 내부의 통계 모델 추정(mirt)이 실패했을 때, 결과 객체의 존재 여부를 검증하지 않고 바로 내부 프로퍼티(@optiminfo$secondordertest)에 접근하여 다운스트림 예외 및 상태 유출이 발생하는 중간 위험도(MEDIUM) 보안 취약점을 해결했습니다. 객체 속성에 접근하기 전 exists('model') 검증을 추가하여 Fail-secure하게 대응하도록 방어적 프로그래밍 패턴을 적용했으며, 추가로 !itemtype == 'ideal' 버그를 수정하고 병렬 처리 중 네임스페이스 함수 충돌을 막기 위해 외부 패키지 함수 호출을 mirt::로 한정했습니다. 관련 학습 내용을 .jules/sentinel.md에 기록했습니다.

---

PR created automatically by Jules for task 9399904207089151873 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[seonghobae]

Order-safe local validation for this PR in the current queue stack:

Stack tested: origin/master + #93 + #108 + #111 + #113 + #115 (5602fbd64578148a17d59b4401691f5aea527e94).

Observed queue-stack merge conflict:

• .jules/sentinel.md conflicts when 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 is applied after 🛡️ Sentinel: [CRITICAL] 다중 음수 grep() 서브셋팅으로 인한 벡터 파괴 취약점 해결 #111/🛡️ Sentinel: [MEDIUM] Add missing input validation on primary arguments #108/⚡ Bolt: R/aFIPC.R 배열 스캔 캐싱을 통한 루프 성능 최적화 #113.
• Local validation resolution kept all Sentinel lessons: Prompt DoS, Unbounded Loop in Model Retry, Vector Wipeout due to Multiple Negative grep() Outputs, Missing Input Validation, and Unhandled Exception Leakage Downstream.
• No PR branch was pushed or restacked from this local validation worktree.

Validation results after that local conflict resolution:

• git diff --check origin/master...HEAD: clean.
• R CMD INSTALL . with local R 4.4.1: DONE (aFIPC).
• Full testthat::test_dir('tests/testthat'): FAIL 0 | WARN 0 | SKIP 0 | PASS 35.
• Exact markdownlint command used by CI: 14 files linted, 0 error(s).

Design/Figma scope check: this repository is still an R package with no frontend/visual surface, so no UI or Figma artifact is warranted for this PR.

This is validation evidence only; merge still needs the required current-head checks and non-stale approval path. When the earlier PRs land, #115 should preserve the local .jules/sentinel.md union above if GitHub reports the same conflict.

[seonghobae]

Updated order-safe local validation after #113 advanced and was corrected to 4f38215.

Current #115 head tested: 5602fbd64578148a17d59b4401691f5aea527e94.

Stack tested: origin/master + #93 + #108 + #111 + #113 (4f38215) + #115.

Observed queue-stack merge conflict:

• .jules/sentinel.md conflicts when 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 is applied after 🛡️ Sentinel: [CRITICAL] 다중 음수 grep() 서브셋팅으로 인한 벡터 파괴 취약점 해결 #111/🛡️ Sentinel: [MEDIUM] Add missing input validation on primary arguments #108/⚡ Bolt: R/aFIPC.R 배열 스캔 캐싱을 통한 루프 성능 최적화 #113.
• Local validation resolution kept all Sentinel lessons: Prompt DoS, Unbounded Loop in Model Retry, Vector Wipeout due to Multiple Negative grep() Outputs, Missing Input Validation, and Unhandled Exception Leakage Downstream.
• No PR branch was pushed or restacked from this local validation worktree.

Validation results after that local conflict resolution:

• git diff --check origin/master...HEAD: clean.
• R CMD INSTALL . with local R 4.4.1: DONE (aFIPC).
• Full testthat::test_dir('tests/testthat'): FAIL 0 | WARN 0 | SKIP 0 | PASS 35.
• Exact markdownlint command used by CI: 14 files linted, 0 error(s).

Design/Figma scope check: this repository is still an R package with no frontend/visual surface, so no UI or Figma artifact is warranted for this PR.

This supersedes the earlier local validation comment that was based on the pre-correction #113 stack. Merge still needs the required current-head checks and non-stale approval path. When the earlier PRs land, #115 should preserve the local .jules/sentinel.md union above if GitHub reports the same conflict.

[seonghobae]

Updated order-safe validation for current #115 head 7e694a1140071d558d342f5a1a7824536cb6ecdd.

Stack tested: origin/master -> #93 -> #108 -> #111 -> #113 -> #115, using current heads:

• docs(AGENTS): keep Figma guidance minimal #93 07dc8dcafcf4db35dd210c83411861dec62473dc
• 🛡️ Sentinel: [MEDIUM] Add missing input validation on primary arguments #108 537bbcb69741eca5b6f15f6e3786c490757f5258
• 🛡️ Sentinel: [CRITICAL] 다중 음수 grep() 서브셋팅으로 인한 벡터 파괴 취약점 해결 #111 edd5e68ca36205f1452f341350cfb5d104ccfa24
• ⚡ Bolt: R/aFIPC.R 배열 스캔 캐싱을 통한 루프 성능 최적화 #113 018abf50c49c17cd87579d7eb2543f88a862331a
• 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 7e694a1140071d558d342f5a1a7824536cb6ecdd

Observed queue-stack merge conflict:

• .jules/sentinel.md still conflicts at the ledger append point.
• Local validation resolution kept all entries: Prompt DoS, Unbounded Loop, Vector Wipeout, Missing Input Validation, and Unhandled Exception Leakage Downstream.
• A deletion-only simulation still conflicted, so I did not push a cosmetic restack. The right time to resolve this is when the lower PRs have landed and 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 is next.

Validation after that local conflict resolution:

• git diff --check origin/master...HEAD passed.
• R CMD INSTALL . passed using local R 4.4.1.
• Full testthat::test_dir('tests/testthat') passed: 35 passes, 0 failures/warnings/skips.

No frontend/Figma artifact is warranted for this R package.

#93 remains the queue head; this is validation-only and does not change merge order.

[seonghobae]

Updated order-safe validation for current #115 head 7e694a1140071d558d342f5a1a7824536cb6ecdd after #113 was corrected to ebeb327a67f362a0be114f904c7e40a10fbb2806.

Stack tested: origin/master -> #93 -> #108 -> #111 -> #113 -> #115, using current heads:

• docs(AGENTS): keep Figma guidance minimal #93 07dc8dcafcf4db35dd210c83411861dec62473dc
• 🛡️ Sentinel: [MEDIUM] Add missing input validation on primary arguments #108 537bbcb69741eca5b6f15f6e3786c490757f5258
• 🛡️ Sentinel: [CRITICAL] 다중 음수 grep() 서브셋팅으로 인한 벡터 파괴 취약점 해결 #111 edd5e68ca36205f1452f341350cfb5d104ccfa24
• ⚡ Bolt: R/aFIPC.R 배열 스캔 캐싱을 통한 루프 성능 최적화 #113 ebeb327a67f362a0be114f904c7e40a10fbb2806
• 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 7e694a1140071d558d342f5a1a7824536cb6ecdd

Observed queue-stack merge conflict:

• .jules/sentinel.md still conflicts at the ledger append point.
• Local validation resolution kept all entries: Prompt DoS, Unbounded Loop, Vector Wipeout, Missing Input Validation, and Unhandled Exception Leakage Downstream.
• No 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 branch edit was pushed; this should be resolved when 🛡️ Sentinel: [MEDIUM] Fix Unhandled Exceptions on Model Estimation Failure #115 becomes the queue head after lower PRs land.

Validation after that local conflict resolution:

• Scoped Trivy config files remained present in the stack.
• git diff --check origin/master...HEAD passed.
• R CMD INSTALL . passed using local R 4.4.1.
• Full testthat::test_dir('tests/testthat') passed: 35 passes, 0 failures/warnings/skips.

No frontend/Figma artifact is warranted for this R package.

#93 remains the queue head; this is validation-only and does not change merge order.

[seonghobae]

Restacked this PR onto the current #113 head 587929bfc080f1897e312e8df2baa906cbf82f32, which includes #111 9cbc785f9eb8400a49c442d11f3fc11e1180ff2d and #108 8347e2a4cc8056dc536881e89c4831a0c87e1e75. New head: b6de687dc77c54d5e4619f9187b6737be31f2369.

Validation on the restacked head:

• git diff --check origin/master...HEAD passed.
• R CMD INSTALL . passed with local R 4.4.1.
• testthat::test_dir('tests/testthat') passed: 34 pass, 0 failures/warnings/skips.
• FIPC-focused tests stayed green: test-autoFIPC.R 6 pass and test-fixed-parameter-calibration.R 23 pass.

The only manual conflict was .jules/sentinel.md; it was resolved by preserving the security ledger entries from both sides and keeping the current path-scoped trivy.yaml guidance instead of stale .trivyignore.yaml guidance. Merge order is unchanged: #108 remains the queue head.

[opencode-agent]

OpenCode Review Overview

• Head SHA: 446df8109fcbe4637bb2bcb59d70948cc8ded5fa
• Workflow run: 29063389042
• Workflow attempt: 1
• Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/sentinel.md.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .jules/sentinel.md to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

• Result: APPROVE
• Reason: The PR addresses a medium-risk security vulnerability by fixing unhandled exceptions in model estimation failure scenarios. The changes are well-justified and tested.
• Head SHA: 446df8109fcbe4637bb2bcb59d70948cc8ded5fa
• Workflow run: 29063389042
• Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]

Loading

[opencode-agent]

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/sentinel.md.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .jules/sentinel.md to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

• Result: APPROVE
• Reason: The PR addresses a medium-risk security vulnerability by fixing unhandled exceptions in model estimation failure scenarios. The changes are well-justified and tested.
• Head SHA: 446df8109fcbe4637bb2bcb59d70948cc8ded5fa
• Workflow run: 29063389042
• Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]

Loading