Skip to content

ci: centralize governance — remove local workflows duplicated by central .github#118

Merged
seonghobae merged 2 commits into
masterfrom
chore/centralize-governance-ci
Jul 10, 2026
Merged

ci: centralize governance — remove local workflows duplicated by central .github#118
seonghobae merged 2 commits into
masterfrom
chore/centralize-governance-ci

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Consolidates governance/security CI into the org CENTRAL required workflows (ContextualWisdomLab/.github).

The removed local workflows duplicate the central required workflows that already execute in this repo's context on every PR:

  • Security Scan (trivy-fs / osv-scan / scorecard)
  • CodeQL PR, OSV-Scanner PR, Scorecard PR

Duplicate local copies cause double runs, duplicate SARIF uploads, and duplicate CRITICAL/HIGH failures. This PR removes only the redundant governance workflows; functional build/test/lint/deploy and gap-filling security (bandit/semgrep/secret-scan/sbom/fuzzing) are left untouched.

Removed:

  • .github/workflows/codeql.yml
  • .github/workflows/dependency-review.yml
  • .github/workflows/scorecard.yml

🤖 Generated with Claude Code

…workflows

These local workflows duplicate the org-wide CENTRAL required workflows in
ContextualWisdomLab/.github (Security Scan = trivy-fs/osv-scan/scorecard,
CodeQL PR, OSV-Scanner PR, Scorecard PR) that already run in this repo's
context on every PR. Keeping local copies causes double runs, duplicate
SARIF uploads, and duplicate CRITICAL/HIGH failures. Removing them so the
central required workflow is the single governance gate.

Removed:
- .github/workflows/codeql.yml
- .github/workflows/dependency-review.yml
- .github/workflows/scorecard.yml

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P
@seonghobae

Copy link
Copy Markdown
Collaborator Author

Order-safe local validation for the current #118 head.

Current #118 head tested: 059bbedb94da128e5ef9ccf12d72b90a6b7b8ed9.

Stack tested: origin/master + #93 + #108 + #111 + #113 (4f38215) + #115 + #117 + #118.

Scope checked:

  • ci: centralize governance — remove local workflows duplicated by central .github #118 deletes only local duplicate workflows: .github/workflows/codeql.yml, .github/workflows/dependency-review.yml, and .github/workflows/scorecard.yml.
  • Active aFIPC rulesets still include CWL Central required workflows, Lock default branch, and PR.
  • The central required workflow rule requires .github/main workflows: close-empty-pr.yml, opencode-review.yml, pr-review-merge-scheduler.yml, security-scan.yml, and strix.yml.
  • Central .github/workflows/security-scan.yml covers OSV, dependency-review, Trivy, and Scorecard jobs. Central CodeQL remains present as codeql-pr.yml; repo-local required status checks remain check, quality, and secret-and-workflow-audit.

Validation results from the disposable stack worktree:

  • git diff --check origin/master...HEAD: clean.
  • R CMD INSTALL . with local R 4.4.1: DONE (aFIPC).
  • Full testthat::test_dir('tests/testthat'): FAIL 0 | WARN 0 | SKIP 0 | PASS 35.
  • Exact markdownlint command used by CI: 14 files linted, 0 error(s).

Design/Figma scope check: this repository is still an R package with no frontend/visual surface, so no UI or Figma artifact is warranted for this PR.

This is validation evidence only; merge still needs the required current-head checks and non-stale approval path.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Order-safe validation for #118 on the current prepared queue stack.

Current #118 head tested: 059bbedb94da128e5ef9ccf12d72b90a6b7b8ed9.

Local stack tested:

Scope checked:

Current governance check:

  • aFIPC rulesets are still active: CWL Central required workflows, Lock default branch, and PR.
  • CWL Central required workflows requires .github/main workflows: close-empty-pr.yml, opencode-review.yml, pr-review-merge-scheduler.yml, security-scan.yml, and strix.yml.
  • Central .github/main also contains codeql-pr.yml, osv-scanner-pr.yml, scorecard-pr.yml, and security-scan.yml; security-scan.yml covers OSV, dependency-review, Trivy, and Scorecard jobs.
  • Local workflows remaining after ci: centralize governance — remove local workflows duplicated by central .github #118 are code-quality.yml, r.yml, and security-audit.yml.

Validation:

  • git diff --check origin/master...HEAD: clean.
  • The package/test stack was already revalidated immediately before this PR on docs: add CWL agent guidance to AGENTS.md #117 with R CMD INSTALL . and full testthat::test_dir('tests/testthat'): FAIL 0 | WARN 0 | SKIP 0 | PASS 34.

No PR branch was pushed or restacked; this is validation evidence only. #118 still needs the required review path before merge.

@opencode-agent

opencode-agent Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: db8a2e23aca72e73bc0b4cb080a197a074659aca
  • Workflow run: 29064092606
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .github/workflows/codeql.yml, .github/workflows/dependency-review.yml, .github/workflows/scorecard.yml.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects .github/workflows/codeql.yml to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: PR consolidates CI workflows without introducing issues
  • Head SHA: db8a2e23aca72e73bc0b4cb080a197a074659aca
  • Workflow run: 29064092606
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow (3 files)"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow (3 files)"]
  R1 --> V1["actionlint plus required checks"]
Loading

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .github/workflows/codeql.yml, .github/workflows/dependency-review.yml, .github/workflows/scorecard.yml.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects .github/workflows/codeql.yml to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: PR consolidates CI workflows without introducing issues
  • Head SHA: db8a2e23aca72e73bc0b4cb080a197a074659aca
  • Workflow run: 29064092606
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow (3 files)"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow (3 files)"]
  R1 --> V1["actionlint plus required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant