π‘οΈ Sentinel: [MEDIUM] Fix unhandled state exception in model failures#123
π‘οΈ Sentinel: [MEDIUM] Fix unhandled state exception in model failures#123seonghobae wants to merge 1 commit into
Conversation
β¦ilures mirt λͺ¨λΈ μΆμ μ€ν¨ μ κ°μ²΄κ° μμ±λμ§ μμ μνμμ μμ±μ μ κ·Όνλ €κ³ νμ¬ λ°μνλ λ°νμ μμΈμ μ μ¬μ μΈ λ΄λΆ μν λμΆ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. try() λΈλ‘ λ΄λΆμ κ²°μ μ μ€λ₯(deterministic errors)λ‘ μΈν΄ κ°μ²΄ μμ±μ΄ μ€ν¨ν κ²½μ°λ₯Ό λλΉνμ¬ isTRUE()μ exists()λ₯Ό νμ©ν μ§§μ μν(short-circuit) νκ°λ₯Ό ν΅ν΄ κ°μ²΄μ μ‘΄μ¬ μ¬λΆλ₯Ό λ¨Όμ νμΈνλλ‘ μ½λλ₯Ό κ°μ νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as superseded by #115, which already merged the unhandled model-state exception fix. I checked #123 against current |
μκ² μ΅λλ€. μ΄ PRμ λ΄μ©μ΄ μ΄λ―Έ λ³ν©λ λ€λ₯Έ PRμ μν΄ λ체λμμμ νμΈνμμΌλ©°, λ μ΄μμ μμ μ μ€λ¨νκ² μ΅λλ€. |
π¨ Severity: MEDIUM
π‘ Vulnerability:
try()λΈλ‘μ ν΅ν λͺ¨λΈ μΆμ κ³Όμ μμ μ€λ₯κ° λ°μν΄ λͺ¨λΈ κ°μ²΄(oldFormModel,newFormModel,LinkedModel)κ° μμ±λμ§ μμμ λ, ν΄λΉ κ°μ²΄μ μ‘΄μ¬ μ¬λΆλ₯Ό νμΈνμ§ μκ³ λ΄λΆ μμ±(@OptimInfo$secondordertest)μ μ κ·Όνμ¬ λ°νμ μμΈ("object not found")κ° λ°μνκ³ μμ€ν μ λ΄λΆ μνκ° λμΆλ μνμ΄ μμμ΅λλ€.π― Impact: μλνλ μν¬νλ‘μ°λ CI/CD νμ΄νλΌμΈ λ± λͺ¨λΈ μΆμ μ΄ κ°νμ μΌλ‘ μ€ν¨νλ νκ²½μμ μ ν리μΌμ΄μ μ κ°μ μ’ λ£κ° λ°μνκ±°λ μκΈ°μΉ μμ μ€λ₯ λ‘κ·Έλ‘ μΈν΄ λ―Όκ°ν λλ²κΉ μ λ³΄κ° λ ΈμΆλ μ μμ΅λλ€.
π§ Fix: κ°μ²΄μ μμ±μ μ κ·ΌνκΈ° μ μ§§μ μν λ°©μ(short-circuit evaluation)μ μ΄μ©ν΄ κ°μ²΄μ μ‘΄μ¬ μ¬λΆ(
exists())λ₯Ό λ¨Όμ νμΈνλλ‘ λ³κ²½νμ΅λλ€.isTRUE()λ₯Ό νμ©νμ¬ ν΄λΉ μμ±μ΄ μκ±°λNULLμΈ κ²½μ°μ μλ¬ λ°©μ§ μ²λ¦¬λ ν¬ν¨λμμ΅λλ€.β Verification: λ¨μ ν μ€νΈ(
tests/testthat/)λ₯Ό λͺ¨λ ν΅κ³ΌνμμΌλ©°,!exists(...) || !isTRUE(...)κ΅¬μ‘°κ° μ¬λ°λ₯΄κ² μλνλμ§ νμΈ μλ£νμ΅λλ€.PR created automatically by Jules for task 9022279950578571025 started by @seonghobae