chore(openspec): Finalize + archive restructure-cli-telemetry - #37
Merged
Conversation
All five phases of the telemetry rework are complete, so finalize on the tip of the stack: apply the analytics delta into the main spec (add the cli_run denominator requirement; rewrite the cli_ taxonomy, the wrong-topic funnel, and the standard-properties scenarios) and move the change to openspec/changes/archive/2026-06-13-restructure-cli-telemetry/. Legacy event sweep is clean (the only _completed is the intentional cli_check_completed concrete event); validate/typecheck/lint/suite green; commands smoke-tested end-to-end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat/telemetry-cli-help: ci(openspec): Skip the archive check on non-tip stacked PRs
This was referenced Jun 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Finalizes the restructure-cli-telemetry OpenSpec change by syncing the analytics spec to the new CLI telemetry taxonomy (with cli_run as the per-invocation denominator) and archiving the completed change set under a dated archive folder.
Changes:
- Updates the main analytics spec to the finalized telemetry taxonomy (adds the “exactly one
cli_runper invocation” requirement, rewritescli_taxonomy + wrong-topic funnel language). - Archives the change (proposal/design/spec deltas + phase checklist) into
openspec/changes/archive/2026-06-13-restructure-cli-telemetry/. - Marks the phase-5 checklist items complete in the archived tasks doc.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/specs/analytics/spec.md | Syncs the main analytics spec to the finalized cli_run + concrete-event telemetry taxonomy and funnel requirements. |
| openspec/changes/archive/2026-06-13-restructure-cli-telemetry/tasks.md | Marks phase-5 verification and archive steps as completed. |
| openspec/changes/archive/2026-06-13-restructure-cli-telemetry/specs/analytics/spec.md | Captures the archived analytics spec delta for the change. |
| openspec/changes/archive/2026-06-13-restructure-cli-telemetry/proposal.md | Archives the rationale and impact summary of the telemetry restructure. |
| openspec/changes/archive/2026-06-13-restructure-cli-telemetry/design.md | Archives design decisions for centralized cli_run and concrete-state events. |
| openspec/changes/archive/2026-06-13-restructure-cli-telemetry/.openspec.yaml | Adds archive metadata for the change bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thecodedrift
marked this pull request as ready for review
June 13, 2026 17:25
thecodedrift
commented
Jun 13, 2026
thecodedrift
left a comment
thecodedrift
left a comment
Member
Author
There was a problem hiding this comment.
deferring to copilot for final spec review
* feat/telemetry-cli-help: fix(cli): Resolve cli_run identity at invocation start, not end test(cli): Prove help_* removal once via a source scan, not per-test test(cli): Assert no legacy help_* event on served-topic and index paths refactor(cli): Single-pass check counts; robust cli_installed assertion fix(cli): Only emit cli_rule_created/improved when rules are written fix(cli): Resolve cli_run identity fresh; tighten cli_error + drop cli_version docs(openspec): Address review on the telemetry contract
…bility
The archive commit synced the pre-review delta spec, so the capability
spec carried the stale cli_check_completed{ filesScanned } and a fuzzy
cli_help index-marker description. Reconcile the synced spec (and the
archive design flow diagram) with the corrected contract: findings
replaces filesScanned, and cli_help documents the exact literal
"(index)" for the no-topic invocation.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat/telemetry-cli-help: refactor(cli): Uppercase the CLI acronym in CliError/CliErrorCode
Match the source rename — the CLI acronym is uppercase in the CLIError class and CLIErrorCode type, so the spec prose and archived contract use the same casing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat/telemetry-cli-help: docs(openspec): Uppercase CLIError/CLIErrorCode in the change contract
* feat/telemetry-cli-help: fix(cli): Carry the CLIErrorCode rename into auth.ts
* feat/telemetry-cli-help: refactor(cli): Uppercase the acronym in CLIErrorEnvelope too
* feat/telemetry-cli-help: refactor(cli): Uppercase the acronym in CLIConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 — finalize (tip of the telemetry stack).
All five phases are complete, so this archives the change: applies the
analyticsdelta into the main spec (adds thecli_rundenominator requirement; rewrites thecli_taxonomy, the wrong-topic funnel, and the standard-properties scenarios) and moves the change toopenspec/changes/archive/2026-06-13-restructure-cli-telemetry/.src/— the only_completedis the intentional concrete eventcli_check_completed.openspec validate/ typecheck / lint / full suite (259) all green.info,help check, andhelp(index) smoke-tested end-to-end after the refactor.Final taxonomy:
cli_run { command, … }per invocation, plus concrete eventscli_rule_created/improved/deleted,cli_authenticated,cli_logged_out,cli_installed,cli_onboarded,cli_check_completed { counts },cli_error { command, code }, andcli_help { topic }.Tip of the
restructure-cli-telemetrystack. The archive check runs (and passes) here; it's skipped on PRs 1–4 per the stack-aware workflow.Stack generated by Git Town