feat(cli): Emit concrete rule events; drop rule start/_completed pairs

[thecodedrift]

Phase 2 of the telemetry rework (stacked on the cli_run phase).

Replaces the per-rule-command start/_completed event pairs with concrete state-transition events fired where the state actually changes:

• rule create → cli_rule_created { ruleCount } (only when rules are written)
• rule improve → cli_rule_improved { ruleCount }
• rule delete → cli_rule_deleted (only when files were removed)
• rule meta / rule verify → no bespoke event; covered by cli_run

create/improve/delete keep their try/finally and emit the concrete event from the finally guarded by a state flag (so it fires only on real success, not the terminal pr/merged/closed states); meta/verify drop their command-level telemetry entirely.

Only a sample event name in telemetry.test.ts referenced an old rule name (updated to cli_rule_created); the rule-from/verify tests assert behavior, not events. Full suite green (256).

Part of the restructure-cli-telemetry OpenSpec change.

---

• main
  • docs(openspec): Propose restructure-cli-telemetry change #33
    • feat(cli): Emit cli_run once per invocation from the runner #32
      • feat(cli): Emit concrete rule events; drop rule start/_completed pairs 👈
        • feat(cli): Concrete auth + lifecycle events; drop start/_completed pairs #35
          • feat(cli): Collapse help_* into cli_help { topic }; drop cli_info #36
            • chore(openspec): Finalize + archive restructure-cli-telemetry #37

^{Stack generated by Git Town}

[Copilot]

Pull request overview

This PR is Phase 2 of the CLI telemetry rework, replacing per-command *_completed telemetry pairs for rule subcommands with concrete state-transition events emitted only when the underlying state actually changes (and dropping bespoke telemetry for rule meta / rule verify, relying on cli_run instead).

Changes:

• Replace cli_rule_create/improve/delete(_completed) telemetry with concrete events: cli_rule_created { ruleCount }, cli_rule_improved { ruleCount }, and cli_rule_deleted.
• Remove command-level telemetry from rule meta and rule verify.
• Update a sample event name in telemetry.test.ts and mark Phase 2 tasks complete in the OpenSpec change checklist.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/cli/src/commands/rules.ts	Drops legacy per-command telemetry and emits concrete rule lifecycle events at the point of successful state change.
packages/cli/test/telemetry.test.ts	Updates the sample captured event name to the new taxonomy.
openspec/changes/restructure-cli-telemetry/tasks.md	Marks Phase 2 checklist items complete and clarifies test impact.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[thecodedrift]

Medium feedback around handling duration. We don't want to lose the timing data, but like cli_run we should move it to the top level so it's not a concern for individual commands