feat(cli): Concrete auth + lifecycle events; drop start/_completed pairs

[thecodedrift]

Phase 3 of the telemetry rework (stacked on the rule-events phase).

Replaces the auth / init / update / onboard / check start + _completed pairs with concrete state-transition events:

• auth login → cli_authenticated (fresh login only — already-logged-in is not a new auth)
• auth logout → cli_logged_out (only when a saved token was actually removed)
• auth status → no bespoke event; covered by cli_run
• init / update → cli_installed (interactive wizard, non-interactive, and update)
• onboard --mark-complete → cli_onboarded (already-done / recipe-print → cli_run only)
• check → cli_check_completed { errorCount, warningCount, findings } — only when a scan actually runs; counts only, never matched code (findings replaces the unavailable filesScanned)

Tests: wizard-integration now asserts cli_installed on completion and no install event on cancel; telemetry.test sample event names updated to cli_run. Full suite green (256).

Part of the restructure-cli-telemetry OpenSpec change. Phase 4 (cli_help) + Phase 5 (finalize/archive) remain.

---

• main
  • docs(openspec): Propose restructure-cli-telemetry change #33
    • feat(cli): Emit cli_run once per invocation from the runner #32
      • feat(cli): Emit concrete rule events; drop rule start/_completed pairs #34
        • feat(cli): Concrete auth + lifecycle events; drop start/_completed pairs 👈
          • feat(cli): Collapse help_* into cli_help { topic }; drop cli_info #36
            • chore(openspec): Finalize + archive restructure-cli-telemetry #37

^{Stack generated by Git Town}

[Copilot]

Pull request overview

Phase 3 of the CLI telemetry rework: replaces command-level “start/_completed” event pairs for auth + lifecycle commands with concrete state-transition events, aligning runtime emission with the updated OpenSpec taxonomy.

Changes:

• Replace legacy auth telemetry events with cli_authenticated (fresh login only) and cli_logged_out (token actually removed); auth status relies on cli_run.
• Replace init/update/wizard completion telemetry with cli_installed; remove cancel/completed pairs.
• Replace check telemetry with cli_check_completed { errorCount, warningCount, findings } emitted only when a scan completes; update tests/docs accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/cli/src/commands/auth.ts	Drops legacy auth start/_completed events; emits concrete auth state events only when appropriate.
packages/cli/src/commands/init.ts	Removes init/update legacy events; emits cli_installed for successful non-interactive install/update paths.
packages/cli/src/wizard/index.ts	Emits cli_installed on successful interactive wizard completion; removes legacy init completed/cancelled events.
packages/cli/src/commands/onboard.ts	Emits cli_onboarded only when onboarding is marked complete; removes other bespoke onboard events.
packages/cli/src/commands/check.ts	Switches to cli_check_completed with counts-only payload emitted only when a scan completes.
packages/cli/test/wizard-integration.test.ts	Updates wizard integration assertions to cli_installed and “no install event on cancel”.
packages/cli/test/telemetry.test.ts	Updates sample event names used by telemetry-client tests to cli_run.
openspec/changes/restructure-cli-telemetry/tasks.md	Marks Phase 3 tasks complete and updates the check payload field to findings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[thecodedrift]

lgtm. Made feedback upstream on handling a cli_completed event so we can reliably capture timing data