Repository navigation
Conversation
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The audio-switch rebuild restores a primary registered subtitle through its registry id, but restores its secondary companion through only the URL. This loses the external identity, explicit headers and selected stream inside a subtitle container. Restore the secondary companion through its existing registry entry too, with coherent teardown and load ownership.
What changed
Test plan
Host: Apple Silicon Mac17,3, macOS 26.7.1, Swift 6.4. Existing synthetic multi-subtitle container fixture; tests verify the selected Spanish stream and registry identity after restoration, teardown, removal, stale-generation publication, embedded selection and same-track dual-channel behavior. Tests exercise the restoration routine called by the audio rebuild, not a physical audio-track switch or an AVPlayer media session. No new device acceptance is claimed for this isolated PR.
LIBDISPATCH_COOPERATIVE_POOL_STRICT=1, including multi-stream restoration and same-track dual-channel compatibility.git diff --checkpassed. Platform builds and all-traits coverage remain for upstream CI.Checklist