Repository navigation
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public secondary-subtitle comments still promise text-only decoding and a second demuxer, although the current packet-store drainer creates independent decoders, cursors and PGS admission state for both channels. Correct that contract and cover the existing bitmap behavior through the actual engine drainer.
This branch also includes the original HLS admission fix from #832, preserving its commit ancestry. Merging #832 first is preferred so this PR’s remaining diff focuses on the subtitle contract and regression.
What changed
This updates the historical contract discussed in #47; it does not introduce a second bitmap pipeline. It is independent of the secondary identity/lifecycle API in #824, although adjacent comments may require a small textual reconciliation.
Initial subtitle-only validation
SubtitlePacketStoreScalingTests2-second wall-time assertion (5.6 seconds under load). No assertions were changed. Full serial rerun passed: 795 XCTest (one existing skip), 4615 Swift Testing tests / 634 suites.git diff --checkpassed. Test executables signed and verified with a valid Apple Development identity; no ad-hoc signing.Checklist
CHANGELOG.mdupdatedCombined-branch validation and CI repair
The original macOS failure came from the pre-existing HLS segment-admission gap. This branch now merges #832 at
1e5353a8debf52e0177a569c24fe8d2f87d5ed3b, preserving that original commit. HLS production code and its regressions are identical to #832; the original bitmap regression is unchanged. The merge required no conflict resolution.At combined head
87ce3bb749205284499bb85d7cfdecaa3ff514ee:git diff --checkpassed.CI follow-up: one same-head diagnostic revalidation
Run 39107721993 tests combined head
87ce3bb749205284499bb85d7cfdecaa3ff514ee. The normal full macOS test step passed, including the original HLS regression. The one-thread cooperative-pool step instead failed in the unchangedItemSwapStillTests.softwareRebuildHoldsThePicture: lines 349–351 reportheld == false,heldPictureLastRoute == nil, andheldPictureLastRelease == nil. This run does not yet establish why the software still was absent. No assertions were removed or relaxed.That test and its held-picture/renderer/loading implementation are unchanged from base
151322d1. Upstream main still points to that base. Inspection of the #711 follow-up and fixture/held-picture history found earlier runner capture/fixture fixes already included in the base, but no verified fix for this exact failure.On the unchanged combined head, a strict-pool focused rerun of held-picture + bitmap + HLS passed (15 tests / 3 suites), and a strict-pool full Swift Testing run passed (4,616 tests / 635 suites). This suggests an intermittent or runner-dependent failure; it does not prove the cause or replace the failed CI result.
The direct job-rerun request was rejected with HTTP 403 (repository admin rights required). The repository also explicitly uses the default pull_request trigger, including reopened. This PR was closed and immediately reopened once, preserving its number, SHA and history, to trigger a diagnostic full revalidation. No code or assertions were changed for that revalidation; the initial failure remains recorded. If the failure repeats, the next investigation needs the held-picture skip reason and outgoing renderer state before proposing a separate fix. The diagnostic revalidation has now completed successfully; see the final result below. This status is separate from physical Dolby Vision playback acceptance.
Final same-head CI result
Revalidation run 39108578203 completed successfully on unchanged head
87ce3bb749205284499bb85d7cfdecaa3ff514ee. All four checks pass: macOS default/all-traits normal and strict-pool suites plus standalone regressions/probes; tvOS/visionOS; iOS/release CLI; documentation links. The latest PR checks report pass and the merge state is CLEAN.The initial held-picture failure above remains part of the evidence. It did not recur in the focused local run, full local strict run or complete CI revalidation; its exact cause remains unconfirmed. No test assertion or held-picture implementation was changed to obtain this result. #832 remains open independently.