Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preserveASSMarkupalready preserves primary sidecar ASS events and their script header, but secondary sidecars silently use the default text decoder and discard the header. Honor the same opt-in option on the secondary channel and publishsecondarySidecarASSHeaderindependently.What changed
SubtitleDecoder; the existing ASS/SSA codec gate keeps SRT/VTT output unchanged.Builds on the existing primary API from #48 and per-stream ASS decoding from #267. All changes are based on main
151322d1b843b4414a0fcffa9ed44e8b3a9d087e; #824 and #825 touch adjacent secondary state/comments but are separate contributions, so merge order may require textual reconciliation.Test plan
SoftwarePacketMemoryFIFOTestshistory-walk assertion withinvalidCursor; reclaimable-history test assumptions are also addressed by open test(cache): respect kernel purges in history eviction checks #819. No unrelated tests were edited; failed evidence was retained.git diff --checkpassed.Checklist
CHANGELOG.mdupdated