i18n(ja): unify execution plan cache notation - #23807
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe changes standardize Japanese plan cache terminology across performance, monitoring, system-variable, configuration, and release documentation. They also rename one Grafana metric label and document logical-import prepared statement support. ChangesPlan Cache Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Severity of issue fixed: Low Merge Risk: 🟡 Moderate · up to This change standardizes Japanese plan-cache terminology, but the documentation still has unresolved ambiguity around cache-mode enablement and several wording inconsistencies. Those could lead users to misinterpret plan-cache behavior or configuration guidance, so clarification is needed before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
the
missing-translation-status
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/M
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 861c6c5e-acb7-4c47-ac40-5a362b8d199f
📒 Files selected for processing (12)
grafana-performance-overview-dashboard.mdperformance-tuning-methods.mdperformance-tuning-practices.mdreleases/release-7.0.0.mdreleases/release-8.2.0.mdreleases/release-8.4.0.mdsql-prepared-plan-cache.mdsystem-variables.mdtidb-cloud/monitor-datadog-integration-for-tidb-x.mdtidb-cloud/monitor-datadog-integration.mdtidb-cloud/monitor-new-relic-integration.mdtidb-performance-tuning-config.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
| TiDBのパフォーマンスを最適化するために、一般的に以下の設定が使用されます。 | ||
|
|
||
| - [SQLプリペアドプランキャッシュ](/sql-prepared-plan-cache.md)などの実行プランキャッシュ[非プリペアドプランキャッシュ](/sql-non-prepared-plan-cache.md)強化します[インスタンスレベルの実行プランキャッシュ](/system-variables.md#tidb_enable_instance_plan_cache-new-in-v840) | ||
| - [SQLプリペアドプランキャッシュ](/sql-prepared-plan-cache.md)、[非プリペアドプランキャッシュ](/sql-non-prepared-plan-cache.md)、[インスタンスレベルの実行プランキャッシュ](/system-variables.md#tidb_enable_instance_plan_cache-new-in-v840)など、実行プランキャッシュを強化します。 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Align the cache-mode guidance across the documents.
This new bullet groups the session prepared cache, session non-prepared cache, and instance-level cache as one recommendation. The SQL block below enables tidb_enable_instance_plan_cache and tidb_enable_non_prepared_plan_cache together. However, system-variables.md recommends disabling session-level prepared and non-prepared caches before enabling the instance-level cache. The documentation gives conflicting operational guidance.
Update the bullet, SQL block, and variable table so they describe one supported combination, or clearly mark the cache modes as alternatives.
As per path instructions, this fix spans noncontiguous Markdown content and requires the supported cache-mode decision, so a committable replacement is not safe here.
Source: Path instructions
yahonda
changed the title
144f2d2 to
ad9868c
Compare
qiancai
added
translation/no-need
d8355f2 to
0c8be8e
Compare
Unify 実行計画キャッシュ/実行計画 キャッシュ to 実行プランキャッシュ where all three forms translate the same EN phrase "execution plan cache" for the same referent.
EN "Still, use the preceding statement as an example:" uses "Still" to mean "continuing with the same example", not a contrast. ただし (however) wrongly implied a contrast that isn't in the source.
…config.md EN links to this page as "SQL Prepared Execution Plan Cache" (capitalized proper noun), while the adjacent "Non-prepared plan cache" link stays lowercase in EN -- so only the first link gains the qualifier, matching each site's own EN capitalization, consistent with pingcap#23809.
0c8be8e to
2df5ece
Compare
…bit review - describe the retrieved plan, not the plan cache, as the object retrieved from the cache - align the clear-execution-plan-cache heading and its trailing sentence to the same 実行プランキャッシュ/実行プラン terms used throughout the section - drop a stray 実行 in the non-prepared-plan-cache warning so it matches the surrounding 非プリペアドプランキャッシュ wording Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai full review |
|
2 participants
What is changed, added or deleted? (Required)
Unifies a same-file, same-EN-phrase notation split for "execution plan cache": most occurrences use 実行プランキャッシュ, but several use 実行計画キャッシュ or a stray-space variant 実行計画 キャッシュ for the exact same EN wording (verified against
release-8.5line-by-line). Also reconstructs a word-order-scrambled sentence intidb-performance-tuning-config.mdlisting the same feature.Bare "plan cache" (プランキャッシュ, without 実行) is intentionally left untouched — it correctly mirrors EN's own separate, more casual "plan cache" wording used in generic prose and dashboard-panel names (e.g. "Queries Using Plan Cache OPS"), which is a distinct rendering from "execution plan cache", not an inconsistency.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
avg-misslabel.