Skip to content

i18n(ja): fix execution-plan-related notation and spacing - #23808

Merged
qiancai merged 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-execution-plan-noun-spacing
Sep 10, 2026
Merged

i18n(ja): fix execution-plan-related notation and spacing#23808
qiancai merged 4 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-execution-plan-noun-spacing

Conversation

@yahonda

@yahonda yahonda commented Sep 10, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Two related fixes to the "execution plan" family of compound terms:

  1. Fixes a corpus-wide MT spacing artifact: a half-width space was inserted between 実行計画 and the word it modifies — 実行計画 バインディング/フェーズ/レベル/ダイジェスト — across 8 files/9 sites. Each site was verified line-by-line against release-8.5 (EN: "execution plan binding(s)/phase/level/digest").

  2. Unifies 実行計画バインディング to 実行プランバインディング — both render the identical EN phrase "execution plan binding(s)" for the same referent (confirmed as a same-file self-contradiction in br-snapshot-manual.md: heading said 実行プランバインディング, body said 実行計画バインディング). Bare "plan binding" (プランバインディング, without 実行) is intentionally left untouched — it correctly mirrors EN's own separate, more casual "plan binding" wording (e.g. the "Fast Plan Binding" feature name), the same EN-driven-variance pattern as the earlier execution-plan-cache fix in i18n(ja): unify execution plan cache notation #23807.

Also fixes a dropped particle and scrambled clause found while reviewing develop/dev-guide-use-subqueries.md.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese terminology and spacing related to execution plans and plan bindings across guides, SQL documentation, and release notes.
    • Improved the Japanese phrasing describing correlated subquery decorrelation and query efficiency.
    • No functional, syntax, behavioral, or permission changes.

@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. labels Sep 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This documentation-only change corrects Japanese execution plan terminology and wording in backup documentation, developer guides, release notes, and SQL statement documentation. It does not change functionality.

Changes

Japanese documentation corrections

Layer / File(s) Summary
Normalize execution plan terminology
br/br-snapshot-manual.md, develop/dev-guide-use-subqueries.md, releases/*.md, sql-statements/sql-statement-create-binding.md
Removes unintended spaces and corrects one subquery explanation in Japanese documentation. No functional content changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Severity of issue fixed: Low

Suggested reviewers: qiancai

Merge Risk: 🔵 Low · up to 01bd6

This documentation update standardizes execution-plan terminology, but one revised release-note sentence remains grammatically incomplete and should add after the link before publication.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the documentation changes, affected version, related reference, AI involvement, and applicable change categories. It is complete enough for review, although it uses the reposi…
Title check ✅ Passed The title clearly identifies the Japanese internationalization change and the execution-plan notation and spacing fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yahonda yahonda changed the title i18n(ja): remove stray space in 実行計画 + noun compounds i18n(ja): remove stray space in execution-plan noun compounds Sep 10, 2026
@yahonda
yahonda force-pushed the fix-execution-plan-noun-spacing branch from 0bcd0df to 61f2253 Compare September 10, 2026 01:00
@yahonda yahonda changed the title i18n(ja): remove stray space in execution-plan noun compounds i18n(ja): fix execution-plan-related notation and spacing Sep 10, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 10, 2026
Fix a corpus-wide MT spacing artifact where a half-width space was
inserted between execution-plan (実行計画) and the word it modifies
(binding, phase, level, digest), verified against release-8.5 line by
line. Term-choice questions (e.g. execution-plan vs execution-plan
katakana form for "binding") are left untouched -- this is a pure
spacing fix, not a notation-unification sweep.
…subqueries.md

EN: "TiDB will try to [Decorrelate of Correlated Subquery] to improve
the query efficiency at the execution plan level." The JA rendering
dropped the object particle after クエリ効率 and attached 向上させる
directly to the link with no connective, reading as a run-on fragment.
Unify 実行計画バインディング to 実行プランバインディング where both
render the same EN phrase "execution plan binding(s)" for the same
referent -- confirmed as a same-file self-contradiction in
br-snapshot-manual.md (heading said 実行プランバインディング, body
said 実行計画バインディング). Bare "plan binding" (プランバインディ
ング, without 実行) is left untouched, since it correctly mirrors EN's
own separate, more casual "plan binding" wording (e.g. the "Fast Plan
Binding" feature name), the same pattern as the earlier plan-cache fix.
@yahonda
yahonda force-pushed the fix-execution-plan-noun-spacing branch from ed6933e to 01bd612 Compare September 10, 2026 04:14

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3464a10f-d6c8-46b0-b2ba-133885985788

📥 Commits

Reviewing files that changed from the base of the PR and between 61f2253 and 01bd612.

📒 Files selected for processing (7)
  • br/br-snapshot-manual.md
  • releases/release-3.0-ga.md
  • releases/release-6.5.12.md
  • releases/release-7.5.5.md
  • releases/release-8.1.0.md
  • releases/release-8.1.2.md
  • sql-statements/sql-statement-create-binding.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread releases/release-8.1.0.md Outdated
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qiancai
qiancai merged commit 9dac7c5 into pingcap:i18n-ja-release-8.5 Sep 10, 2026
2 of 8 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-10 05:47:10.935062282 +0000 UTC m=+1949466.106156396: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants