Skip to content

i18n(ja): add missing execution qualifier to plan cache proper noun - #23809

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-plan-cache-title-consistency
Sep 10, 2026
Merged

i18n(ja): add missing execution qualifier to plan cache proper noun#23809
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-plan-cache-title-consistency

Conversation

@yahonda

@yahonda yahonda commented Sep 10, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

EN consistently names this feature "SQL (Non-)Prepared Execution Plan Cache" everywhere it appears as a proper noun (page titles, TOC entries, formal doc links). The JA page titles themselves (sql-prepared-plan-cache.md, sql-non-prepared-plan-cache.md) and 3 of 5 TOC files (TOC-tidb-cloud.md, TOC-tidb-cloud-premium.md, TOC-tidb-cloud-starter.md) dropped the "execution" qualifier (プリペアドプランキャッシュ), while TOC.md, TOC-tidb-cloud-essential.md, and system-variable-reference.md already included it (プリペアド実行プランキャッシュ). Also translates sql-non-prepared-plan-cache.md's H1, which was left as literal English.

Generic lowercase "prepared plan cache" mentions elsewhere in the corpus are intentionally untouched — EN itself uses that shorter, casual form in many places (verified line-by-line against release-8.5), and JA correctly mirrors it there. Only sites where EN uses the capitalized proper-noun form were changed.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated Japanese documentation titles, summaries, and table-of-contents entries to consistently use terminology for prepared and non-prepared execution plan caches.
    • Updated the related benchmark documentation link text to match the revised terminology.
    • Link destinations and technical content remain unchanged.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a7b51c48-063d-4cca-8297-28c22934767c

📥 Commits

Reviewing files that changed from the base of the PR and between a2da298 and dc590a2.

📒 Files selected for processing (6)
  • TOC-tidb-cloud-premium.md
  • TOC-tidb-cloud-starter.md
  • TOC-tidb-cloud.md
  • benchmark/benchmark-tidb-using-sysbench.md
  • sql-non-prepared-plan-cache.md
  • sql-prepared-plan-cache.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The change updates Japanese terminology for prepared and non-prepared execution plan caches in documentation headings, summaries, table-of-contents entries, and a benchmark reference. Link targets remain unchanged.

Changes

Plan cache terminology

Layer / File(s) Summary
Update plan cache page terminology
sql-prepared-plan-cache.md, sql-non-prepared-plan-cache.md
Updated page summaries and headings to use execution plan cache terminology.
Align navigation and benchmark references
TOC-tidb-cloud-premium.md, TOC-tidb-cloud-starter.md, TOC-tidb-cloud.md, benchmark/benchmark-tidb-using-sysbench.md
Updated prepared execution plan cache link labels. All link targets remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 35262

Japanese plan-cache documentation now consistently uses the execution-plan-cache terminology while preserving existing navigation and links. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese localization change and the addition of the execution qualifier to the plan cache proper noun.
Description check ✅ Passed The description explains the scope, rationale, affected Japanese TiDB 8.5 documentation, references the follow-up issue, and completes the applicable checklist items. The optional first-time contribut…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

yahonda added a commit to yahonda/docs that referenced this pull request Sep 10, 2026
…config.md

EN links to this page as "SQL Prepared Execution Plan Cache" (capitalized
proper noun), while the adjacent "Non-prepared plan cache" link stays
lowercase in EN -- so only the first link gains the qualifier, matching
each site's own EN capitalization, consistent with pingcap#23809.
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 10, 2026
EN consistently names this feature "SQL (Non-)Prepared Execution Plan
Cache" everywhere it appears as a proper noun (page titles, TOC
entries, formal doc links), but the JA page titles themselves and 3 of
5 TOC files dropped the "execution" qualifier, while TOC.md,
TOC-tidb-cloud-essential.md, and system-variable-reference.md already
included it. Also translates sql-non-prepared-plan-cache.md's H1,
which was left as literal English.

Generic lowercase "prepared plan cache" mentions elsewhere in the
corpus are untouched -- EN itself uses that shorter, casual form in
many places, and JA correctly mirrors it there.
yahonda added a commit to yahonda/docs that referenced this pull request Sep 10, 2026
…config.md

EN links to this page as "SQL Prepared Execution Plan Cache" (capitalized
proper noun), while the adjacent "Non-prepared plan cache" link stays
lowercase in EN -- so only the first link gains the qualifier, matching
each site's own EN capitalization, consistent with pingcap#23809.
@yahonda
yahonda force-pushed the fix-plan-cache-title-consistency branch from dc590a2 to 352623c Compare September 10, 2026 04:14
yahonda added a commit to yahonda/docs that referenced this pull request Sep 10, 2026
…config.md

EN links to this page as "SQL Prepared Execution Plan Cache" (capitalized
proper noun), while the adjacent "Non-prepared plan cache" link stays
lowercase in EN -- so only the first link gains the qualifier, matching
each site's own EN capitalization, consistent with pingcap#23809.
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-10 05:52:51.980830002 +0000 UTC m=+1949807.151924138: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 8971f31 into pingcap:i18n-ja-release-8.5 Sep 10, 2026
3 of 8 checks passed
yahonda added a commit to yahonda/docs that referenced this pull request Sep 11, 2026
…config.md

EN links to this page as "SQL Prepared Execution Plan Cache" (capitalized
proper noun), while the adjacent "Non-prepared plan cache" link stays
lowercase in EN -- so only the first link gains the qualifier, matching
each site's own EN capitalization, consistent with pingcap#23809.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants