Skip to content

Revert "Add tls-scanner-run to RHOAI e2e job" - #82675

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
davidebianchi:revert-82555-rhoai-tls-scanner
Jul 30, 2026
Merged

Revert "Add tls-scanner-run to RHOAI e2e job"#82675
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
davidebianchi:revert-82555-rhoai-tls-scanner

Conversation

@davidebianchi

@davidebianchi davidebianchi commented Jul 30, 2026

Copy link
Copy Markdown
Member

The check is failing in opendatahub-operator and blocking PRs, without an evidence that it passed before.

We'll revert it, and it should be restored in a future PR

Summary by CodeRabbit

Removes the failing tls-scanner-run check and its related configuration from the opendatahub-operator RHOAI end-to-end CI job, preventing it from blocking pull requests.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d9a62cdb-bb40-448d-936e-ff1dc77418d7

📥 Commits

Reviewing files that changed from the base of the PR and between 253e50a and 692eb5e.

📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml

Walkthrough

The operator CI pipeline removes the TLS scanner base image, scan-related environment variables, and tls-scanner-run step from the RHOAI end-to-end job.

Changes

TLS scanner wiring removal

Layer / File(s) Summary
Remove TLS scanner configuration
ci-operator/config/opendatahub-io/opendatahub-operator/...
The pipeline removes the TLS scanner base image and related PQC/scan environment variables.
Remove TLS scanner step
ci-operator/config/opendatahub-io/opendatahub-operator/...
The RHOAI end-to-end job no longer references tls-scanner-run before the generic claim workflow.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting the tls-scanner-run addition to the RHOAI e2e job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML changed; no Ginkgo test titles or specs were added or modified.
Test Structure And Quality ✅ Passed Only a CI config YAML changed; no Ginkgo test code was added or modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; this PR only removes a CI tls-scanner step from a YAML config, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only edits ci-operator YAML to remove tls-scanner config; it adds no new Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator test config changed; it removes tls-scanner-related env and steps, with no deployment manifests, operators, or scheduling constraints added.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML changed; no process-level code or stdout writes were touched, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only removes tls-scanner ci-operator config from a job, so IPv4/external-connectivity checks are not applicable.
No-Weak-Crypto ✅ Passed Diff only removes TLS-scanner CI config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed The PR only removes tls-scanner-related CI config; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Diff only removes tls-scanner/PQC job wiring; no new logging or sensitive-value exposure was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlkyrillos, davidebianchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026
@openshift-ci
openshift-ci Bot requested review from dayakar349 and kahowell July 30, 2026 15:52
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davidebianchi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-opendatahub-operator-main-images opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-e2e opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-rhoai-e2e opendatahub-io/opendatahub-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@carlkyrillos

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@carlkyrillos: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@davidebianchi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4727ba9 into openshift:main Jul 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants