Move tls-scanner-run to post phase with best_effort for opendatahub-o… - #82676
Move tls-scanner-run to post phase with best_effort for opendatahub-o…#82676GowthamShanmugam wants to merge 1 commit into
Conversation
…perator The TLS scanner is a read-only audit step that should not block PRs on failure. Moving it from the test phase to post with best_effort ensures e2e results are not affected by scanner issues. Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThe OpenDataHub operator E2E job now runs ChangesOpenDataHub TLS scanner
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@GowthamShanmugam, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml`:
- Around line 161-163: Regenerate the downstream CI artifacts affected by the
tls-scanner-run entry in the opendatahub-operator configuration using the
repository’s standard generation target, such as make update or the equivalent
jobs and metadata targets, then include all resulting generated diffs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 6edfb373-d2dc-439a-9498-981d417fd418
📒 Files selected for processing (1)
ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml
| post: | ||
| - ref: tls-scanner-run | ||
| best_effort: true |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
make registry-metadata && make ci-operator-config && make jobsRepository: openshift/release
Length of output: 197
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Makefile =="
if [ -f Makefile ]; then
sed -n '1,220p' Makefile | nl -ba | sed -n '1,220p'
else
echo "No Makefile at repository root"
fi
echo
echo "== ci-operator config file excerpt =="
FILE="ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml"
if [ -f "$FILE" ]; then
wc -l "$FILE"
sed -n '130,180p' "$FILE" | nl -ba -v130
else
echo "Missing $FILE"
fi
echo
echo "== Generated files that may be affected =="
git ls-files | rg 'generated|metadata|prow|jobs|ci-operator|opendatahub-io-opendatahub-operator-main' | sed -n '1,200p'
echo
echo "== Make invocations in git history / current diff =="
git diff --stat || true
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,220p' || trueRepository: openshift/release
Length of output: 210
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Makefile =="
if [ -f Makefile ]; then
sed -n '1,220p' Makefile
else
echo "No Makefile at repository root"
fi
echo
echo "== ci-operator config file excerpt =="
FILE="ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml"
if [ -f "$FILE" ]; then
wc -l "$FILE"
sed -n '130,180p' "$FILE"
else
echo "Missing $FILE"
fi
echo
echo "== Generated files that may be affected =="
git ls-files | grep -E 'generated|metadata|prow|jobs|ci-operator|opendatahub-io-opendatahub-operator-main' | sed -n '1,200p'
echo
echo "== Diff for target file =="
git diff -- ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml | sed -n '1,260p' || true
echo
echo "== Target workflow/config references =="
python3 - <<'PY'
from pathlib import Path
for p in list(Path('.').glob('**/*'))[:20]:
pass
print("Python available")
PYRepository: openshift/release
Length of output: 30176
Regenerate the downstream CI artifacts for this ci-operator change.
ci-operator/config/ changes are the source of truth for generated metadata/Prow jobs. Run the repo’s generation target, e.g. make update (or make jobs ci-operator-config registry-metadata), and commit any generated diffs before merge.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-main.yaml`
around lines 161 - 163, Regenerate the downstream CI artifacts affected by the
tls-scanner-run entry in the opendatahub-operator configuration using the
repository’s standard generation target, such as make update or the equivalent
jobs and metadata targets, then include all resulting generated diffs.
Sources: Coding guidelines, Learnings
|
@GowthamShanmugam we can close this in favour of #82675 |
|
@GowthamShanmugam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
…perator
The TLS scanner is a read-only audit step that should not block PRs on failure. Moving it from the test phase to post with best_effort ensures e2e results are not affected by scanner issues.
Summary by CodeRabbit
opendatahub-operatorend-to-end CI job to runtls-scanner-runafter the test phase as a best-effort post step.