Repository navigation
fix(lint): publish as comark-linter, since npm refuses comark-lint as too close to remark-lint - #55
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
…and a resolver other plugins share
… too close to remark-lint
fbe6abc to
1cc4f66
Compare
Latest result Pull request merged. Final answersSession Pull request merged. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed docs/build.ts after its checks ran; waiting for checks on the new head. Session Current HEAD is verified and all required checks pass. Pullfrog’s historical P1 syntax finding is fixed; lockfile, package documentation, badge, and chart-reference findings are resolved or stale. No unresolved actionable threads remain. The push window forbids edits or commits, so no repair was needed; the PR is ready for host merge. |
comark-annotate
comark-carousel
comark-charts
comark-code
comark-embed
comark-github-callouts
comark-icon
comark-include
comark-linter
comark-tabs
comark-zoom
commit: |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
ℹ️ One user-facing package-name reference remains stale; the rename itself is otherwise consistent.
Reviewed changes
- Published package rename — Changed the package and workspace dependency to
comark-linterwhile retaining the intentionalcomark-lintCLI, config, and diagnostic identifiers. - Documentation and site metadata — Updated package installation/import guidance, agent instructions, the charts skill, and the docs build's npm-name mapping.
- Release/build metadata — Updated the package's
prepackfilter and lockfile importer; the release workflow still discovers all packages throughpackages/*.
ℹ️ A package reference still uses the retired name
docs/pages/charts/guides.md:28 still labels the linter as [comark-lint], even though this PR changes the published package and the lint page metadata to comark-linter. Because this is prose describing the package rather than the intentionally retained executable or rule name, users may infer that they should install or search for the unavailable comark-lint package.
Technical details
# Update the remaining package-name reference
## Affected sites
- `docs/pages/charts/guides.md:28` — the link text says `comark-lint` while referring to the published package.
## Required outcome
- Use `comark-linter` whenever prose refers to the published package, while retaining `comark-lint` for the executable, config filename, and diagnostic identifiers.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Published package rename — Renamed the workspace and published package to
comark-linterwhile retaining the intentionalcomark-lintCLI, config filename, and diagnostic identifiers. - Documentation and tooling references — Updated package installation/import guidance, agent instructions, the charts skill, the root Doctor config, and the docs build's npm-name mapping.
- Release metadata — Updated the package
prepackfilter and lockfile importer to usecomark-linter.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Corrected package documentation — Updated the remaining chart guide reference from
comark-lintto the published package namecomark-linter.
The remaining comark-lint references are intentional executable, config, rule, diagnostic, or test identifiers.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Caution
The merge-resolution commit leaves a changed test file syntactically invalid, so the workspace check cannot parse and verify the PR.
Reviewed changes
- Merge-resolution result — Rechecked the current head against the prior Pullfrog review, including the conflict-resolution changes and their effect on the full PR.
- Icon test fixture — Inspected the updated issue-reporting test and verified the new syntax failure with
pnpm exec vp check.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
Important
The latest merge result leaves the package README's npm badges pointing at the unavailable comark-lint package, so the published package's version, downloads, install-size, and license links remain broken or misleading.
Reviewed changes
- Merged branch updates — Rechecked the merge of
feat/tabs-iconsinto the linter rename branch and its interaction with the package-name changes. - Package README badges — Rechecked the latest README metadata and package-versus-command naming split.
⚠️ Package badges still target the retired package name
The README now identifies the package as comark-linter, but all four npmx badge URLs still use comark-lint. Readers following those links will be sent to the retired package name instead of the package this PR publishes.
Technical details
# Update package badge targets
## Affected sites
- `packages/lint/README.md:3-6` — the npm version, downloads, install-size, and license badge URLs and links still use `comark-lint`.
## Required outcome
- Point every package and registry badge at `comark-linter`.
- Keep `comark-lint` only for the executable, config filename, and diagnostic identifiers.
gpt-5.6-sol ｜ 𝕏
|
Pullfrog P1 syntax finding fixed by restoring the icon markdown fixture and issues assertion; package README badge targets were corrected to comark-linter. Local validation was blocked by the sandbox pnpm SQLite cache path; hosted checks should verify the repair. |
There was a problem hiding this comment.
Important
The latest commits introduce two installability regressions: the workspace lockfile is stale, and the Vite Doctor documentation points users at a package that is not published.
Reviewed changes
- Renamed the executable — Changed the lint binary and its user-facing CLI/config references from
comark-linttolint-comark. - Expanded the playground — Added editable JSON configuration, config sharing, JSON highlighting, and responsive preset thumbnail fitting.
- Repaired merged fixtures and metadata — Restored the icon issue test and corrected the lint package's npm badge targets.
⚠️ The workspace dependency is missing from the lockfile
The root package.json now declares lint-comark, but the lockfile importer only contains comark-linter. A frozen install therefore fails before CI can build or test the workspace, as confirmed by pnpm exec vp check reporting ERR_PNPM_OUTDATED_LOCKFILE.
Technical details
# Synchronize the root workspace dependency
## Affected sites
- `package.json:36` — adds `lint-comark: workspace:*`.
- `pnpm-lock.yaml:119-121` — contains the `comark-linter` importer entry but no matching `lint-comark` entry.
## Required outcome
- Make the root package manifest and `pnpm-lock.yaml` describe the same workspace dependencies so frozen installs succeed.
⚠️ The Vite Doctor page installs and imports the wrong package
The published package is comark-linter, but the updated Vite Doctor page tells users to install lint-comark and import lint-comark/doctor. That package does not exist for this PR, so the documented setup cannot install or resolve the Doctor extension.
Technical details
# Keep Vite Doctor guidance on the published package name
## Affected sites
- `docs/pages/lint/vite-doctor.md:4` — installs `lint-comark` instead of `comark-linter`.
- `docs/pages/lint/vite-doctor.md:9-13` — imports `lint-comark/doctor` instead of `comark-linter/doctor`.
## Required outcome
- Install and import `comark-linter`; retain `lint-comark` only where the executable name is intended.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
docs/pages/lint/vite-doctor.md:4(RIGHT) — file not in PR diff
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Corrected Vite Doctor documentation — Updated the new Vite Doctor page to install and import the published
comark-linterpackage while retaininglint-comarkonly for the executable and config naming. - Revalidated package metadata — Confirmed the prior lockfile, icon-test, badge, and package-name findings are resolved in the current head; no additional stale published-package references remain.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the fixture repair committed since the prior Pullfrog review.
- Restored icon test fixture — Reinstated the single-string Markdown input and the render assertion so the icon issue test is syntactically valid and exercises both rendering and diagnostics again.
The prior syntax-error feedback is addressed. Verification was attempted, but pnpm's read-only prepare step failed while trying to lock .git/config; the lockfile check itself reported that the lockfile is up to date.
gpt-5.6-sol ｜ 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This incremental review covers the merge of main into feat/comark-linter since the prior Pullfrog review.
- Merged current base — Rechecked the merge-resolution changes in
docs/build.tsand their interaction with the publishedcomark-linterpackage mapping. - Revalidated prior fixes — Confirmed that the synchronized workspace dependency and lockfile, corrected Vite Doctor guidance, package badges, and restored icon test fixture remain intact.
gpt-5.6-sol ｜ 𝕏
1 participant
npm refuses to publish
comark-lint: "Package name too similar to existing package remark-lint". So the package becomescomark-linter. The name is already claimed on npm underonmax_, withrelease.yamland environmentnpmset as its trusted publisher.Only the package name changes. The command, the config file, the messages, and the rule names stay
comark-lint:What changed:
packages/lint/package.jsonand the root dev dependency.doctor.config.ts.npx comark-linter).This has to merge before the next release. Until it does, the release workflow would try to publish
comark-lintand fail with a 403.🤖 Generated with Claude Code