Repository navigation
docs(lint): a guide for running comark-lint next to ESLint or oxlint, and as part of Vite Doctor - #68
Conversation
…and a resolver other plugins share
… too close to remark-lint
… and as part of Vite Doctor
Latest result Pull request merged. Final answersSession Pull request merged. Session Updated the branch with main because main changed AGENTS.md, README.md, docs/build.ts and 15 more after its checks ran; waiting for checks on the new head. Session Waiting for open parent PR #55 to merge; this child has nothing left to repair. Verified the expected HEAD, guide diff, repository instructions, current checks, and review feedback. All current required checks and exact-base checks pass; Pullfrog reported no new issues and there are no actionable threads. No repair commit is needed. Local lint invocation was blocked by pnpm’s non-TTY module purge, but hosted validation is green. Session Waiting for feat/comark-linter to pass: its tip fails the same checks as this PR (check / check). Session Waiting for feat/comark-linter to pass: its tip fails the same checks as this PR (check / check). Session Waiting for feat/comark-linter to pass: its tip fails the same checks as this PR (check / check). Session Waiting for feat/comark-linter to pass: its tip fails the same checks as this PR (check / check). Session Waiting for feat/comark-linter to pass: its tip fails the same checks as this PR (check / check). |
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The guide added in docs/pages/lint/guides.md was reviewed against the current comark-linter CLI, Vite Doctor extension, and docs navigation.
- Lint integrations — Documents valid ESLint and oxlint scripts, quoted CLI globs,
lint-stagedfile paths, and CI usage. - Vite Doctor integration — Uses the published
comark-linter/doctorentry point, supportedincludeoption, recommended preset, and the necessary--max-warnings 0behavior. - Docs integration — The new
guidespage is picked up by the existing lint section ordering and links to the existing Vite Doctor documentation.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-carousel
comark-charts
comark-code
comark-embed
comark-github-callouts
comark-icon
comark-include
comark-linter
comark-tabs
comark-zoom
commit: |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The post-review synchronization merge was checked against the prior Pullfrog review; it introduces no net changes to the guide or new behavioral surface.
- Synchronized the branch — Merged the current
mainhistory into the PR branch without changingdocs/pages/lint/guides.mdrelative to the previously reviewed commit.
gpt-5.6-sol ｜ 𝕏
1 participant
Stacked on #55. This adds
lint/guides, a short page that sits between Getting started and Vite Doctor in the lint section.::blocks, so comark-lint goes into the samelintscript. A code group shows the line for each linter.*.{md,mdc}. comark-lint takes file paths as well as globs.pnpm lintstep covers both.COMARK000xcodes, an agent report, and SARIF output. It links to the existing Vite Doctor page for the options.I checked the commands against a scratch project:
comark-lintwith relative and absolute paths exits 1 on problems.extends: ["auto", "comark/recommended"]loads both.--max-warnings 0, and the page says why.--format sarifwrites SARIF 2.1.0.pnpm run lint:docsreports 0 problems, andnode docs/build.tswrites/lint/guides/with the code group rendered as tabs.This PR changes no code. If
checkfails here, the cause is in #55:packages/icon/test/icon.test.ts:136has an unescaped'inside a single-quoted string, sovp fmt --checkfails on that branch too.🤖 Generated with Claude Code