Repository navigation
feat(renderer): adopt data router navigation - #3593
Merged
Merged
Conversation
Replace the declarative HashRouter/Routes tree with a single createHashRouter route table and RouterProvider. Move the window chrome, global shortcuts, and sidebar into a root layout route, and the login guard into a protected layout route. Share sidebar destinations and shortcut routes through nav.ts, render route destinations as NavLinks, and return to the requested destination after login. Add a catch-all route for unknown hashes. Upgrade react-router-dom@7.18.5 to react-router@8.5.0, update imports, test helpers, mocks, and the packaged-dependency check.
github-actions
Bot
added
dependency
Restore literal t() keys for the sidebar copy so removeUnusedKeys keeps them, and leave nav.ts as paths and shortcuts only.
Expose the active destination with aria-current instead of rendering route controls as links. This avoids the Primer link-specific icon sizing workaround and keeps the existing toggle behavior without click interception.
|
setchy
marked this pull request as ready for review
November 1, 2026 20:25
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the renderer from the declarative
react-router-dom@7.18.5<HashRouter>+<Routes>tree to a single React Router 8 data-router table.react-router-dom@7.18.5withreact-router@8.5.0and updates every renderer/test import, mock, and the packaged-dependency check.router.tsxas the single route table withcreateHashRouterandRouterProviderfromreact-router/dom.RootLayoutroute for the app shell (sidebar, global shortcuts, routed<Outlet />) and aProtectedLayoutroute for the login guard.nav.ts; the active destination is exposed witharia-currentwhile every control stays anIconButton.Verification
pnpm checkpnpm test— 2090 passedpnpm test:visual— 176 passed in the pinned Linux containerpnpm buildDeferred
08-adopt-data-router-navigation) is not recorded yet. The router change is not presented as a fix for that toggle.